Switch to primitive support in QNSPSA #8682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
Changelog: Deprecation
Cryoris
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3156403740
💛 - Coveralls |
woodsp-ibm
reviewed
Sep 6, 2022
ElePT
reviewed
Sep 28, 2022
|
Thank you @ElePT and @woodsp-ibm for pushing this over the finish line! 🙂 |
woodsp-ibm
reviewed
Sep 29, 2022
woodsp-ibm
reviewed
Sep 29, 2022
woodsp-ibm
approved these changes
Sep 29, 2022
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
ElePT
added a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* switch to primitive support in QNSPSA * attempt to fix sphinx & cyclic import * add comment about sampler passed positionally * Update typehints * revert import * Apply suggestions from code review Co-authored-by: ElePT <[email protected]> Co-authored-by: ElePT <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Steve Wood <[email protected]>
ElePT
added a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* switch to primitive support in QNSPSA * attempt to fix sphinx & cyclic import * add comment about sampler passed positionally * Update typehints * revert import * Apply suggestions from code review Co-authored-by: ElePT <[email protected]> Co-authored-by: ElePT <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Steve Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the Sampler and Fidelity subroutines in
QNSPSA.get_fidelityinstead of the backend and opflow expectation converter. Using the latter now yields a pending deprecation warning.Details and comments
The code also became a lot cleaner since we can now just use the
ComputeUncomputefidelity instead of computing the overlap manually.I'm not quite sure if this counts as "New Feature" so feel free to untag!