Remove pulse defaults for old fake 20q backends #8665

mtreinish · 2022-09-02T14:16:45Z

Summary

The pulse defaults payload for the almaden, johannesburg, and singapore
fake backends are collectively taking up > 50% of the total disk
footprint of an installed copy of Qiskit. This is because the pusle
defaults for these backends predate the use the of parameterized pulse
definitions and contain arrays of sampled waveforms for the pulse
definitions. This exceedingly large file size slows down the entire
package and and makes it slower to install. When weighing the potential
value these defaults files provide for simulating and compiling with
pulse awareness for long retired devices against the real cost of
having the files included in the package there isn't a reason to keep
the files in the tree any longer. This commit removes the pulse
defaults files for these fake backends to greatly shrink the installed
package size of qiskit-terra.

Details and comments

The pulse defaults payload for the almaden, johannesburg, and singapore fake backends are collectively taking up > 50% of the total disk footprint of an installed copy of Qiskit. This is because the pusle defaults for these backends predate the use the of parameterized pulse definitions and contain arrays of sampled waveforms for the pulse definitions. This exceedingly large file size slows down the entire package and and makes it slower to install. When weighing the potential value these defaults files provide for simulating and compiling with pulse awareness for long retired devices against the real cost of having the files included in the package there isn't a reason to keep the files in the tree any longer. This commit removes the pulse defaults files for these fake backends to greatly shrink the installed package size of qiskit-terra.

qiskit-bot · 2022-09-02T14:16:50Z

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@Qiskit/terra-core

releasenotes/notes/remove-pulse-defs-old-20q-4ed46085b4a15678.yaml

…yaml

jakelishman

Absolutely fine by me to get rid of these. They're not so heavy for the download of the wheels (due to the compression), but it just seems like good bookkeeping to clear out cruft from devices that have been offline for however long.

jakelishman · 2022-09-02T14:51:27Z

Some of the tests explicitly use the Almaden, Johannesburg and Singapore fakes in part because they had pulse defaults - those will need changing over.

nkanazawa1989

I'm also fine with removing them. These pulse data could be used for pulse simulation, but Hamiltonian parameters in configuration are usually off from calibration and useless apart from testing of the visualization module (because we don't update Hamiltonian with calibrations).

Several tests and docs were relying on the pulse data being present in the fake backends. This commit updates the tests and docs to avoid this and either rely on different fake backends that use parametric pulses or not rely on a fake backend at all. In one case a bug is fixed the assembler which was causing the tests to incorrectly pass because the use of pulse backends without parametric pulses was masking incorrect behavior.

mtreinish · 2022-09-12T17:54:58Z

ok, I've updated the tests to no longer rely on these backends having pulse defaults present. Hopefully things will pass now (this also caught a bug in the assembler which was masked by the use of the old backends).

coveralls · 2022-09-12T18:22:16Z

Pull Request Test Coverage Report for Build 3148486327

10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 84.508%

Totals
Change from base Build 3148484315:	0.06%
Covered Lines:	60260
Relevant Lines:	71307

💛 - Coveralls

In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning.

mtreinish · 2022-09-12T19:35:02Z

The tutorials failure should be fixed once: Qiskit/qiskit-tutorials#1356 merges

In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning. We previously updated one tutorial in Qiskit#1356 however there were more uses of FakeAlmaden in other tutorials so things were still blocked. This commit updates all the other uses of FakeAlmaden to use a provider that will have pulse properties moving forward.

* Update more pulse gate tutorial for changes in fake backends In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning. We previously updated one tutorial in #1356 however there were more uses of FakeAlmaden in other tutorials so things were still blocked. This commit updates all the other uses of FakeAlmaden to use a provider that will have pulse properties moving forward. * Update tutorials/circuits_advanced/08_gathering_system_information.ipynb Co-authored-by: Luciano Bello <[email protected]>

jakelishman

Looks good to me - the diff looks cleaner without the +1,800 file as well! I'm never very sure if we should be making assertions about the exact forms of those giant reprs anyway.

releasenotes/notes/remove-pulse-defs-old-20q-4ed46085b4a15678.yaml

mtreinish · 2022-09-28T19:39:07Z

Looks good to me - the diff looks cleaner without the +1,800 file as well! I'm never very sure if we should be making assertions about the exact forms of those giant reprs anyway.

Heh, that took me longer to track down than I care to admit. My default editor config was changing the whitespace and I thought I somehow broke the output as part of the unrelated change which is why I changed the backend and added that file. But once I figured out what I did wrong it was easy to fix.

…1358) * Update more pulse gate tutorial for changes in fake backends In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning. We previously updated one tutorial in Qiskit#1356 however there were more uses of FakeAlmaden in other tutorials so things were still blocked. This commit updates all the other uses of FakeAlmaden to use a provider that will have pulse properties moving forward. * Update tutorials/circuits_advanced/08_gathering_system_information.ipynb Co-authored-by: Luciano Bello <[email protected]>

In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning.

In Qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning.

…qiskit-tutorials#1358) * Update more pulse gate tutorial for changes in fake backends In Qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning. We previously updated one tutorial in Qiskit/qiskit-tutorials#1356 however there were more uses of FakeAlmaden in other tutorials so things were still blocked. This commit updates all the other uses of FakeAlmaden to use a provider that will have pulse properties moving forward. * Update tutorials/circuits_advanced/08_gathering_system_information.ipynb Co-authored-by: Luciano Bello <[email protected]>

In Qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning.

…qiskit-tutorials#1358) * Update more pulse gate tutorial for changes in fake backends In Qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning. We previously updated one tutorial in Qiskit/qiskit-tutorials#1356 however there were more uses of FakeAlmaden in other tutorials so things were still blocked. This commit updates all the other uses of FakeAlmaden to use a provider that will have pulse properties moving forward. * Update tutorials/circuits_advanced/08_gathering_system_information.ipynb Co-authored-by: Luciano Bello <[email protected]>

* Remove pulse defaults for old fake 20q backends The pulse defaults payload for the almaden, johannesburg, and singapore fake backends are collectively taking up > 50% of the total disk footprint of an installed copy of Qiskit. This is because the pusle defaults for these backends predate the use the of parameterized pulse definitions and contain arrays of sampled waveforms for the pulse definitions. This exceedingly large file size slows down the entire package and and makes it slower to install. When weighing the potential value these defaults files provide for simulating and compiling with pulse awareness for long retired devices against the real cost of having the files included in the package there isn't a reason to keep the files in the tree any longer. This commit removes the pulse defaults files for these fake backends to greatly shrink the installed package size of qiskit-terra. * Update releasenotes/notes/remove-pulse-defs-old-20q-4ed46085b4a15678.yaml * Update tests and docs Several tests and docs were relying on the pulse data being present in the fake backends. This commit updates the tests and docs to avoid this and either rely on different fake backends that use parametric pulses or not rely on a fake backend at all. In one case a bug is fixed the assembler which was causing the tests to incorrectly pass because the use of pulse backends without parametric pulses was masking incorrect behavior. * Revert passmanager config string test changes * Remove self.maxDiff in str test * Fix missing backtick Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning.

…qiskit-tutorials#1358) * Update more pulse gate tutorial for changes in fake backends In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning. We previously updated one tutorial in Qiskit/qiskit-tutorials#1356 however there were more uses of FakeAlmaden in other tutorials so things were still blocked. This commit updates all the other uses of FakeAlmaden to use a provider that will have pulse properties moving forward. * Update tutorials/circuits_advanced/08_gathering_system_information.ipynb Co-authored-by: Luciano Bello <[email protected]>

In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning.

…qiskit-tutorials#1358) * Update more pulse gate tutorial for changes in fake backends In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning. We previously updated one tutorial in Qiskit/qiskit-tutorials#1356 however there were more uses of FakeAlmaden in other tutorials so things were still blocked. This commit updates all the other uses of FakeAlmaden to use a provider that will have pulse properties moving forward. * Update tutorials/circuits_advanced/08_gathering_system_information.ipynb Co-authored-by: Luciano Bello <[email protected]>

In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning.

…qiskit-tutorials#1358) * Update more pulse gate tutorial for changes in fake backends In Qiskit/qiskit#8665 very large pulse properties for long retired 20q backends are removed to save disk space and reduce overhead. However the pulse gates tutorial was still relying on these fake backends having pulse properties. This commit updates the tutorial to use a different backend to unblock that PR. Additionally, the deprecate import statements used in the tutorial are updated to avoid the deprecation warning. We previously updated one tutorial in Qiskit/qiskit-tutorials#1356 however there were more uses of FakeAlmaden in other tutorials so things were still blocked. This commit updates all the other uses of FakeAlmaden to use a provider that will have pulse properties moving forward. * Update tutorials/circuits_advanced/08_gathering_system_information.ipynb Co-authored-by: Luciano Bello <[email protected]>

* Remove pulse defaults for old fake 20q backends The pulse defaults payload for the almaden, johannesburg, and singapore fake backends are collectively taking up > 50% of the total disk footprint of an installed copy of Qiskit. This is because the pusle defaults for these backends predate the use the of parameterized pulse definitions and contain arrays of sampled waveforms for the pulse definitions. This exceedingly large file size slows down the entire package and and makes it slower to install. When weighing the potential value these defaults files provide for simulating and compiling with pulse awareness for long retired devices against the real cost of having the files included in the package there isn't a reason to keep the files in the tree any longer. This commit removes the pulse defaults files for these fake backends to greatly shrink the installed package size of qiskit-terra. * Update releasenotes/notes/remove-pulse-defs-old-20q-4ed46085b4a15678.yaml * Update tests and docs Several tests and docs were relying on the pulse data being present in the fake backends. This commit updates the tests and docs to avoid this and either rely on different fake backends that use parametric pulses or not rely on a fake backend at all. In one case a bug is fixed the assembler which was causing the tests to incorrectly pass because the use of pulse backends without parametric pulses was masking incorrect behavior. * Revert passmanager config string test changes * Remove self.maxDiff in str test * Fix missing backtick Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

mtreinish requested review from a team and jyu00 as code owners September 2, 2022 14:16

mtreinish added the Changelog: API Change Include in the "Changed" section of the changelog label Sep 2, 2022

jakelishman reviewed Sep 2, 2022

View reviewed changes

releasenotes/notes/remove-pulse-defs-old-20q-4ed46085b4a15678.yaml Outdated Show resolved Hide resolved

Update releasenotes/notes/remove-pulse-defs-old-20q-4ed46085b4a15678.…

1d98488

…yaml

jakelishman previously approved these changes Sep 2, 2022

View reviewed changes

nkanazawa1989 previously approved these changes Sep 6, 2022

View reviewed changes

mtreinish dismissed stale reviews from nkanazawa1989 and jakelishman via 9ac25a9 September 12, 2022 17:52

mtreinish requested a review from nonhermitian as a code owner September 12, 2022 17:52

Merge remote-tracking branch 'origin/main' into drop-pulse-defs-old-20q

7a37094

mtreinish mentioned this pull request Sep 12, 2022

Update pulse gate tutorial for changes in fake backends Qiskit/qiskit-tutorials#1356

Merged

Merge branch 'main' into drop-pulse-defs-old-20q

a4ed6ac

mtreinish mentioned this pull request Sep 21, 2022

Update more pulse gate tutorial for changes in fake backends Qiskit/qiskit-tutorials#1358

Merged

Merge branch 'main' into drop-pulse-defs-old-20q

b856442

jakelishman added this to the 0.22 milestone Sep 21, 2022

mtreinish assigned kdk Sep 27, 2022

mtreinish added 3 commits September 28, 2022 11:21

Merge remote-tracking branch 'origin/main' into drop-pulse-defs-old-20q

e8604c8

Revert passmanager config string test changes

1eba685

Remove self.maxDiff in str test

a6ef585

jakelishman previously approved these changes Sep 28, 2022

View reviewed changes

releasenotes/notes/remove-pulse-defs-old-20q-4ed46085b4a15678.yaml Outdated Show resolved Hide resolved

Fix missing backtick

57f7341

jakelishman dismissed their stale review via 57f7341 September 28, 2022 19:13

jakelishman approved these changes Sep 28, 2022

View reviewed changes

jakelishman added the automerge label Sep 28, 2022

Merge branch 'main' into drop-pulse-defs-old-20q

a21466c

mergify bot merged commit 594ad01 into Qiskit:main Sep 29, 2022

mtreinish deleted the drop-pulse-defs-old-20q branch September 29, 2022 11:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove pulse defaults for old fake 20q backends #8665

Remove pulse defaults for old fake 20q backends #8665

mtreinish commented Sep 2, 2022

qiskit-bot commented Sep 2, 2022

jakelishman left a comment

jakelishman commented Sep 2, 2022

nkanazawa1989 left a comment

mtreinish commented Sep 12, 2022 •

edited

Loading

coveralls commented Sep 12, 2022 •

edited

Loading

mtreinish commented Sep 12, 2022

jakelishman left a comment

mtreinish commented Sep 28, 2022

Remove pulse defaults for old fake 20q backends #8665

Remove pulse defaults for old fake 20q backends #8665

Conversation

mtreinish commented Sep 2, 2022

Summary

Details and comments

qiskit-bot commented Sep 2, 2022

jakelishman left a comment

Choose a reason for hiding this comment

jakelishman commented Sep 2, 2022

nkanazawa1989 left a comment

Choose a reason for hiding this comment

mtreinish commented Sep 12, 2022 • edited Loading

coveralls commented Sep 12, 2022 • edited Loading

Pull Request Test Coverage Report for Build 3148486327

💛 - Coveralls

mtreinish commented Sep 12, 2022

jakelishman left a comment

Choose a reason for hiding this comment

mtreinish commented Sep 28, 2022

mtreinish commented Sep 12, 2022 •

edited

Loading

coveralls commented Sep 12, 2022 •

edited

Loading