Fix maxfun default in L_BFGS
#8285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Cryoris
added
Changelog: Removal
Pull Request Test Coverage Report for Build 2601339986
💛 - Coveralls |
Cryoris
changed the title
L_BFGS_B and fix maxfun defaultmaxfun default in L_BFGS
woodsp-ibm
reviewed
Jul 1, 2022
| maxiter: int = 15000, | ||
| ftol: float = 10 * np.finfo(float).eps, | ||
| factr: Optional[float] = None, |
There was a problem hiding this comment.
Seems this delete should have been done as part of #8210 but at least you caught it here!
woodsp-ibm
approved these changes
Jul 2, 2022
gentinettagian
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jul 4, 2022
* Fix maxfun and rm deprecated arg * update docs, rm "epsilon" * add reno * lint * update reno
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Fix maxfun and rm deprecated arg * update docs, rm "epsilon" * add reno * lint * update reno
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Fix maxfun and rm deprecated arg * update docs, rm "epsilon" * add reno * lint * update reno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8251 and updates the docstrings to properly show math and code.
Details and comments
See #8251 for details on the
maxfunupdate.