Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version number to 0.21.0rc1 for first release candidate #8200

Merged
merged 9 commits into from
Jun 22, 2022

Conversation

mtreinish
Copy link
Member

Summary

For the 0.21.0 release we're going to start pushing release candidates
prior to the release to enable testing before we cut the final release.
In preparation for tagging the first release candidate this commit
updates the version string to indicate it's a release candidate.

Details and comments

For the 0.21.0 release we're going to start pushing release candidates
prior to the release to enable testing before we cut the final release.
In preparation for tagging the first release candidate this commit
updates the version string to indicate it's a release candidate.
@mtreinish mtreinish requested a review from a team as a code owner June 17, 2022 19:24
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish
Copy link
Member Author

I debated doing the release notes for this PR, but we can wait for that until we tag the real release since we're not publishing the rc1 release notes (or at least I wasn't planning on it because we don't bump the metapackage).

@mtreinish mtreinish added the Changelog: None Do not include in changelog label Jun 17, 2022
@mtreinish mtreinish added this to the 0.21 milestone Jun 17, 2022
@mtreinish mtreinish requested a review from nkanazawa1989 as a code owner June 17, 2022 20:35
@coveralls
Copy link

coveralls commented Jun 17, 2022

Pull Request Test Coverage Report for Build 2543447384

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 84.289%

Totals Coverage Status
Change from base Build 2542722489: 0.001%
Covered Lines: 54971
Relevant Lines: 65217

💛 - Coveralls

mtreinish added a commit to mtreinish/qiskit-ibmq-provider that referenced this pull request Jun 20, 2022
In the upcoming terra release there will be a release candidate tagged
prior to the final release. However changing the version string for the
package is blocked on the ibmq provider right now because it is trying
to parse the version and is assuming there will be no prelease suffix on
the version string (see Qiskit/qiskit#8200 for the details). This
commit fixes this version parsing to use the regex from the
pypa/packaging project which handles all the PEP440 package versioning
include pre-release suffixes. This will enable terra to release an
0.21.0rc1 tag without breaking the ibmq provider.
rathishcholarajan added a commit to Qiskit/qiskit-ibmq-provider that referenced this pull request Jun 20, 2022
In the upcoming terra release there will be a release candidate tagged
prior to the final release. However changing the version string for the
package is blocked on the ibmq provider right now because it is trying
to parse the version and is assuming there will be no prelease suffix on
the version string (see Qiskit/qiskit#8200 for the details). This
commit fixes this version parsing to use the regex from the
pypa/packaging project which handles all the PEP440 package versioning
include pre-release suffixes. This will enable terra to release an
0.21.0rc1 tag without breaking the ibmq provider.

Co-authored-by: Rathish Cholarajan <[email protected]>
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, this looks fine to me. Assuming all the issues with the IBMQ provider are fixed now, this looks good to merge.

A minor unrelated question: does the Cargo.lock file get automatically updated (on build) only because the Cargo.toml changed, or is it just that we haven't been committing other changes that might have occurred?

@mtreinish
Copy link
Member Author

A minor unrelated question: does the Cargo.lock file get automatically updated (on build) only because the Cargo.toml changed, or is it just that we haven't been committing other changes that might have occurred?

That's on me. I had run cargo update locally to bump things as part of an MSRV test and I committed it when I bumped the version string in the Cargo.toml. It was a conscious decision on my part I figure get everything up to date since it works with the new msrv prior to the release. (but I can revert it if you'd prefer)

Typically the Cargo.lock won't be updated unless you change something in the Cargo.toml and rebuild (and then it will only be related to that change) or you manually update it. So in this case if I hadn't run cargo update the only change to the Cargo.lock would be the qiskit-terra crate version bump: https://github.com/Qiskit/qiskit-terra/pull/8200/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR344

rathishcholarajan added a commit to Qiskit/qiskit-ibmq-provider that referenced this pull request Jun 21, 2022
In the upcoming terra release there will be a release candidate tagged
prior to the final release. However changing the version string for the
package is blocked on the ibmq provider right now because it is trying
to parse the version and is assuming there will be no prelease suffix on
the version string (see Qiskit/qiskit#8200 for the details). This
commit fixes this version parsing to use the regex from the
pypa/packaging project which handles all the PEP440 package versioning
include pre-release suffixes. This will enable terra to release an
0.21.0rc1 tag without breaking the ibmq provider.

Co-authored-by: Rathish Cholarajan <[email protected]>
@mergify mergify bot merged commit 5a6ec94 into Qiskit:main Jun 22, 2022
@mtreinish mtreinish deleted the prep-for-rc1 branch June 22, 2022 16:55
mtreinish added a commit to mtreinish/qiskit-core that referenced this pull request Jun 24, 2022
As pointed out by @nkanazawa1989 in Qiskit#8232 the regex construction added
to the QPY interface functions in Qiskit#8200 can be a significant portion of
the overall function time especially for smaller inputs. Especially as
we're building it on every call interface function call. To ameliorate
that cost this commit compiles the version regex a single time at the
module level. This adds the overhead to import but it will only be done
once which should be a net improvement in performance.
mergify bot added a commit that referenced this pull request Jun 24, 2022
* Move QPY version regex construction to import time

As pointed out by @nkanazawa1989 in #8232 the regex construction added
to the QPY interface functions in #8200 can be a significant portion of
the overall function time especially for smaller inputs. Especially as
we're building it on every call interface function call. To ameliorate
that cost this commit compiles the version regex a single time at the
module level. This adds the overhead to import but it will only be done
once which should be a net improvement in performance.

* Fix regex flags usage

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot pushed a commit that referenced this pull request Jun 24, 2022
* Move QPY version regex construction to import time

As pointed out by @nkanazawa1989 in #8232 the regex construction added
to the QPY interface functions in #8200 can be a significant portion of
the overall function time especially for smaller inputs. Especially as
we're building it on every call interface function call. To ameliorate
that cost this commit compiles the version regex a single time at the
module level. This adds the overhead to import but it will only be done
once which should be a net improvement in performance.

* Fix regex flags usage

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit ebf800a)
mergify bot added a commit that referenced this pull request Jun 24, 2022
* Move QPY version regex construction to import time

As pointed out by @nkanazawa1989 in #8232 the regex construction added
to the QPY interface functions in #8200 can be a significant portion of
the overall function time especially for smaller inputs. Especially as
we're building it on every call interface function call. To ameliorate
that cost this commit compiles the version regex a single time at the
module level. This adds the overhead to import but it will only be done
once which should be a net improvement in performance.

* Fix regex flags usage

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit ebf800a)

Co-authored-by: Matthew Treinish <[email protected]>
rathishcholarajan added a commit to rathishcholarajan/qiskit-ibm-runtime that referenced this pull request Jul 5, 2022
Co-authored-by: Matthew Treinish <[email protected]>
rathishcholarajan added a commit to Qiskit/qiskit-ibm-runtime that referenced this pull request Jul 5, 2022
* Copy Qiskit/qiskit#8055

Co-authored-by: Matthew Treinish <[email protected]>

* Copy qpy changes from Qiskit/qiskit#8093

Co-authored-by: Jake Lishman <[email protected]>
Co-authored-by: Jake Lishman <[email protected]>

* Copy Qiskit/qiskit#8200

Co-authored-by: Matthew Treinish <[email protected]>

* Copy of Qiskit/qiskit#7300

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Naoki Kanazawa <[email protected]>

* Copy of Qiskit/qiskit#8235

Co-authored-by: Matthew Treinish <[email protected]>

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Jake Lishman <[email protected]>
Co-authored-by: Jake Lishman <[email protected]>
Co-authored-by: Naoki Kanazawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants