-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set version number to 0.21.0rc1 for first release candidate #8200
Conversation
For the 0.21.0 release we're going to start pushing release candidates prior to the release to enable testing before we cut the final release. In preparation for tagging the first release candidate this commit updates the version string to indicate it's a release candidate.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
I debated doing the release notes for this PR, but we can wait for that until we tag the real release since we're not publishing the rc1 release notes (or at least I wasn't planning on it because we don't bump the metapackage). |
Pull Request Test Coverage Report for Build 2543447384
💛 - Coveralls |
In the upcoming terra release there will be a release candidate tagged prior to the final release. However changing the version string for the package is blocked on the ibmq provider right now because it is trying to parse the version and is assuming there will be no prelease suffix on the version string (see Qiskit/qiskit#8200 for the details). This commit fixes this version parsing to use the regex from the pypa/packaging project which handles all the PEP440 package versioning include pre-release suffixes. This will enable terra to release an 0.21.0rc1 tag without breaking the ibmq provider.
In the upcoming terra release there will be a release candidate tagged prior to the final release. However changing the version string for the package is blocked on the ibmq provider right now because it is trying to parse the version and is assuming there will be no prelease suffix on the version string (see Qiskit/qiskit#8200 for the details). This commit fixes this version parsing to use the regex from the pypa/packaging project which handles all the PEP440 package versioning include pre-release suffixes. This will enable terra to release an 0.21.0rc1 tag without breaking the ibmq provider. Co-authored-by: Rathish Cholarajan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, this looks fine to me. Assuming all the issues with the IBMQ provider are fixed now, this looks good to merge.
A minor unrelated question: does the Cargo.lock
file get automatically updated (on build) only because the Cargo.toml
changed, or is it just that we haven't been committing other changes that might have occurred?
That's on me. I had run Typically the |
In the upcoming terra release there will be a release candidate tagged prior to the final release. However changing the version string for the package is blocked on the ibmq provider right now because it is trying to parse the version and is assuming there will be no prelease suffix on the version string (see Qiskit/qiskit#8200 for the details). This commit fixes this version parsing to use the regex from the pypa/packaging project which handles all the PEP440 package versioning include pre-release suffixes. This will enable terra to release an 0.21.0rc1 tag without breaking the ibmq provider. Co-authored-by: Rathish Cholarajan <[email protected]>
As pointed out by @nkanazawa1989 in Qiskit#8232 the regex construction added to the QPY interface functions in Qiskit#8200 can be a significant portion of the overall function time especially for smaller inputs. Especially as we're building it on every call interface function call. To ameliorate that cost this commit compiles the version regex a single time at the module level. This adds the overhead to import but it will only be done once which should be a net improvement in performance.
* Move QPY version regex construction to import time As pointed out by @nkanazawa1989 in #8232 the regex construction added to the QPY interface functions in #8200 can be a significant portion of the overall function time especially for smaller inputs. Especially as we're building it on every call interface function call. To ameliorate that cost this commit compiles the version regex a single time at the module level. This adds the overhead to import but it will only be done once which should be a net improvement in performance. * Fix regex flags usage Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Move QPY version regex construction to import time As pointed out by @nkanazawa1989 in #8232 the regex construction added to the QPY interface functions in #8200 can be a significant portion of the overall function time especially for smaller inputs. Especially as we're building it on every call interface function call. To ameliorate that cost this commit compiles the version regex a single time at the module level. This adds the overhead to import but it will only be done once which should be a net improvement in performance. * Fix regex flags usage Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ebf800a)
* Move QPY version regex construction to import time As pointed out by @nkanazawa1989 in #8232 the regex construction added to the QPY interface functions in #8200 can be a significant portion of the overall function time especially for smaller inputs. Especially as we're building it on every call interface function call. To ameliorate that cost this commit compiles the version regex a single time at the module level. This adds the overhead to import but it will only be done once which should be a net improvement in performance. * Fix regex flags usage Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ebf800a) Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
* Copy Qiskit/qiskit#8055 Co-authored-by: Matthew Treinish <[email protected]> * Copy qpy changes from Qiskit/qiskit#8093 Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: Jake Lishman <[email protected]> * Copy Qiskit/qiskit#8200 Co-authored-by: Matthew Treinish <[email protected]> * Copy of Qiskit/qiskit#7300 Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Naoki Kanazawa <[email protected]> * Copy of Qiskit/qiskit#8235 Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: Naoki Kanazawa <[email protected]>
Summary
For the 0.21.0 release we're going to start pushing release candidates
prior to the release to enable testing before we cut the final release.
In preparation for tagging the first release candidate this commit
updates the version string to indicate it's a release candidate.
Details and comments