-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelizing scheduling of multiple circuits via parallel_map. #8110
Parallelizing scheduling of multiple circuits via parallel_map. #8110
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking on this task. Overall the code is straightforward enoguh and LGTM, just a few small inline comments in the test. Also before we merge this can you add a feature release note documenting that schedule()
will execute in parallel for >1 circuit now so that we document this change. You can find the details on adding release notes
Pull Request Test Coverage Report for Build 2461276100
💛 - Coveralls |
@mtreinish Would you be willing to give these changes another review? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, this is looking better, just a couple of small inline comments mainly around the new tests and how you're monkey patch sys
.
Thank you for the additional review, @mtreinish! I've addressed your most recent set of comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the updates
Summary
Fixes #2695 by using
parallel_map
instead of a list comprehension when scheduling multiple circuits to run on a backend.Details and comments
A new file was added for unit tests corresponding to
qiskit/compiler/scheduler.py
, as such a file did not exist previously. The tests confirm that scheduling continues to operate as intended following these changes. Additional tests were added to cover code paths that raise exceptions.