-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated classes and methods in quantum_info #8070
Remove deprecated classes and methods in quantum_info #8070
Conversation
…antum-info/rm-deprecated-pauli
…/ikkoham/qiskit-core into quantum-info/rm-deprecated-pauli
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2548390936
💛 - Coveralls |
I noticed that the deprecated path is used in Aer (Qiskit/qiskit-aer#1521). So we can't merge this PR until Aer is released. |
@daiki0623 @ikkoham Is this part of QAMP? If so, can you please link to the project issue in the description of the PR? I will also add the |
Thank you, added QAMP link in the description. |
This is failing CI because the operators tutorial is using I push Qiskit/qiskit-tutorials#1339 to update the tutorials, but maybe we want to hold off for a cycle on this and ensure we're actually emitting proper warnings before we remove it. |
This commit updates the operator tutorial to avoid the deprecated Pauli constructor kwarg, label. This has been deprecated since Qiskit Terra 0.17.0 and is pending removal in Qiskit/qiskit#8070. The label kwarg isn't needed anymore as the Pauli string can just be input directly as the first positional argument and the Pauli object will be created just as with the label kwarg before.
That's on me - the PR had a I bet the issue is that the stack level If we reinstate the deprecation on the initialiser for this cycle, that's probably best. |
@mtreinish: I've reinstated the constructors whose deprecations failed to show, and left everything else removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I hadn't thought of a way to use __getitem__
to generate DeprecationWarning
. Thanks.
I'll make it a comment so it doesn't get automerged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick update restoring and fixing the deprecation warnings.
This commit updates the operator tutorial to avoid the deprecated Pauli constructor kwarg, label. This has been deprecated since Qiskit Terra 0.17.0 and is pending removal in Qiskit/qiskit#8070. The label kwarg isn't needed anymore as the Pauli string can just be input directly as the first positional argument and the Pauli object will be created just as with the label kwarg before.
…it#1339) This commit updates the operator tutorial to avoid the deprecated Pauli constructor kwarg, label. This has been deprecated since Qiskit Terra 0.17.0 and is pending removal in Qiskit/qiskit#8070. The label kwarg isn't needed anymore as the Pauli string can just be input directly as the first positional argument and the Pauli object will be created just as with the label kwarg before.
…it/qiskit-tutorials#1339) This commit updates the operator tutorial to avoid the deprecated Pauli constructor kwarg, label. This has been deprecated since Qiskit Terra 0.17.0 and is pending removal in Qiskit#8070. The label kwarg isn't needed anymore as the Pauli string can just be input directly as the first positional argument and the Pauli object will be created just as with the label kwarg before.
…it/qiskit-tutorials#1339) This commit updates the operator tutorial to avoid the deprecated Pauli constructor kwarg, label. This has been deprecated since Qiskit Terra 0.17.0 and is pending removal in Qiskit#8070. The label kwarg isn't needed anymore as the Pauli string can just be input directly as the first positional argument and the Pauli object will be created just as with the label kwarg before.
…it/qiskit-tutorials#1339) This commit updates the operator tutorial to avoid the deprecated Pauli constructor kwarg, label. This has been deprecated since Qiskit Terra 0.17.0 and is pending removal in Qiskit/qiskit#8070. The label kwarg isn't needed anymore as the Pauli string can just be input directly as the first positional argument and the Pauli object will be created just as with the label kwarg before.
…it/qiskit-tutorials#1339) This commit updates the operator tutorial to avoid the deprecated Pauli constructor kwarg, label. This has been deprecated since Qiskit Terra 0.17.0 and is pending removal in Qiskit/qiskit#8070. The label kwarg isn't needed anymore as the Pauli string can just be input directly as the first positional argument and the Pauli object will be created just as with the label kwarg before.
…it/qiskit-tutorials#1339) This commit updates the operator tutorial to avoid the deprecated Pauli constructor kwarg, label. This has been deprecated since Qiskit Terra 0.17.0 and is pending removal in Qiskit/qiskit#8070. The label kwarg isn't needed anymore as the Pauli string can just be input directly as the first positional argument and the Pauli object will be created just as with the label kwarg before.
Summary
This is a part of QAMP #20