Fix marginal_counts on memory with non-zero indices
#8047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
The marginalisation could previously return the empty string instead of `"0"` if the given indices were too high for a given memory slot, causing a later error in binary-to-hex conversion.
jakelishman
force-pushed
the
fix-marginal-memory-zeros
branch
from
c9cff10 to
194138f
Compare
Pull Request Test Coverage Report for Build 2307080453
💛 - Coveralls |
mtreinish
reviewed
May 11, 2022
mtreinish
approved these changes
May 11, 2022
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
I still haven't quite figured out how to make the mergify bot update its statuses correctly. Probably it just needs to run through the test suite again. |
mergify bot
pushed a commit
that referenced
this pull request
May 11, 2022
The marginalisation could previously return the empty string instead of `"0"` if the given indices were too high for a given memory slot, causing a later error in binary-to-hex conversion. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9374449)
mergify bot
added a commit
that referenced
this pull request
May 11, 2022
The marginalisation could previously return the empty string instead of `"0"` if the given indices were too high for a given memory slot, causing a later error in binary-to-hex conversion. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9374449) Co-authored-by: Jake Lishman <[email protected]>
ajavadia
pushed a commit
to ajavadia/qiskit
that referenced
this pull request
May 31, 2022
The marginalisation could previously return the empty string instead of `"0"` if the given indices were too high for a given memory slot, causing a later error in binary-to-hex conversion. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The marginalisation could previously return the empty string instead of
"0"if the given indices were too high for a given memory slot,causing a later error in binary-to-hex conversion.
Details and comments
Fix #8044.