-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of eval_observables() when quantum_circuit is a StateFn. #7863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StateFn(StateFn()) actually returns an OperatorStateFn. This caused an issue that was not checked by the test cases test_aux_ops_evaluator.py. The associated test case was added.
Anthony-Gandon
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
April 1, 2022 17:38
Cryoris
added
the
Changelog: Bugfix
Include in the "Fixed" section of the changelog
label
Apr 2, 2022
Cryoris
reviewed
Apr 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment on the release note, otherwise LGTM!
Cryoris
added
the
stable backport potential
The bug might be minimal and/or import enough to be port to stable
label
Apr 2, 2022
Pull Request Test Coverage Report for Build 2090306568
💛 - Coveralls |
Co-authored-by: Julien Gacon <[email protected]>
Cryoris
reviewed
Apr 4, 2022
Cryoris
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
* Fix the eval_observables() when quantum_state is StateFn. StateFn(StateFn()) actually returns an OperatorStateFn. This caused an issue that was not checked by the test cases test_aux_ops_evaluator.py. The associated test case was added. * Add the associated releasenote * Update releasenotes/notes/fix-aux-ops-evaluator-83ce1606d1ad19b3.yaml Co-authored-by: Julien Gacon <[email protected]> * Fix sphinx identifier Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a296ca0)
mergify bot
added a commit
that referenced
this pull request
Apr 4, 2022
…7881) * Fix the eval_observables() when quantum_state is StateFn. StateFn(StateFn()) actually returns an OperatorStateFn. This caused an issue that was not checked by the test cases test_aux_ops_evaluator.py. The associated test case was added. * Add the associated releasenote * Update releasenotes/notes/fix-aux-ops-evaluator-83ce1606d1ad19b3.yaml Co-authored-by: Julien Gacon <[email protected]> * Fix sphinx identifier Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a296ca0) Co-authored-by: Anthony-Gandon <[email protected]>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
…7863) * Fix the eval_observables() when quantum_state is StateFn. StateFn(StateFn()) actually returns an OperatorStateFn. This caused an issue that was not checked by the test cases test_aux_ops_evaluator.py. The associated test case was added. * Add the associated releasenote * Update releasenotes/notes/fix-aux-ops-evaluator-83ce1606d1ad19b3.yaml Co-authored-by: Julien Gacon <[email protected]> * Fix sphinx identifier Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
…qiskit#7863) * Fix the eval_observables() when quantum_state is StateFn. StateFn(StateFn()) actually returns an OperatorStateFn. This caused an issue that was not checked by the test cases test_aux_ops_evaluator.py. The associated test case was added. * Add the associated releasenote * Update releasenotes/notes/fix-aux-ops-evaluator-83ce1606d1ad19b3.yaml Co-authored-by: Julien Gacon <[email protected]> * Fix sphinx identifier Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the "Fixed" section of the changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
StateFn(StateFn()) actually returns an OperatorStateFn.
This caused an error in _prepare_list_op that was not checked by the test cases in test_aux_ops_evaluator.py.
The associated test case was added.
Previous error message: