Expand instruction_supported() to optionally check parameters #7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit expands the recently added instruction_supported() method of the Target class to also enable optionally checking if a parameter on an instruction is supported. This is anticipating future changes around how instruction parameters are represented in terra more generally as part of Qiskit#7624 and specifically in the Target for Qiskit#7797. Before we do any refactoring around this having a standard API for checking if a parameter is supported is useful. This commit expands the interface for the insturction_supported() method to check any combination of operation name, qargs, operation class, or parameters (either operation name or class is required) and the method will return True if that instruction can be run on the Target device.
Pull Request Test Coverage Report for Build 2544541175
💛 - Coveralls |
mtreinish
commented
Mar 31, 2022
Co-authored-by: Ali Javadi-Abhari <[email protected]>
jakelishman
reviewed
May 3, 2022
mtreinish
added
Changelog: New Feature
|
I need to add a release note now since |
jakelishman
reviewed
Jun 22, 2022
|
Oops my bad I left the comment to remind myself and forgot to circle back and add the release note. I just pushed it up in 2777b1f |
jakelishman
reviewed
Jun 22, 2022
releasenotes/notes/expand-instruction-supported-c3c9a02b2faa9785.yaml
Outdated
Show resolved
Hide resolved
jakelishman
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit expands the recently added instruction_supported() method of
the Target class to also enable optionally checking if a parameter on an
instruction is supported. This is anticipating future changes around how
instruction parameters are represented in terra more generally as part
of #7624 and specifically in the Target for #7797. Before we do any
refactoring around this having a standard API for checking if a
parameter is supported is useful. This commit expands the interface for
the insturction_supported() method to check any combination of
operation name, qargs, operation class, or parameters (either operation
name or class is required) and the method will return True if that
instruction can be run on the Target device.
Details and comments