Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cython as a build dependency #7777

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Remove Cython as a build dependency #7777

merged 1 commit into from
Mar 14, 2022

Conversation

garrison
Copy link
Member

Summary

This follows up on #7702, which removed the last of the Cython code. The current change was was presumably intended to be part of that PR, I think, based on the release note added there:

Cython is no longer a build dependency of Qiskit Terra and is no longer required to be installed when building Qiskit Terra from source.

@mtreinish

Details and comments

@garrison
Remove Cython as a build dependency
ae87a2c 
This follows up on Qiskit#7702, which removed the last of the Cython code.
The current change was was presumably intended to be part of that
PR, I think, based on the release note added there:

> Cython is no longer a build dependency of Qiskit Terra and is no
> longer required to be installed when building Qiskit Terra from
> source.
@garrison garrison requested a review from a team as a code owner March 14, 2022 20:51
mtreinish
mtreinish approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yeah I missed this in #7702. I updated the setup.py and removed all the build machinery but forgot about the pyproject.toml (and didn't even realize we had cython in the requirements-dev.txt). I should have done more grepping in #7702 thanks for fixing this.

@mtreinish mtreinish added automerge Changelog: None Do not include in changelog labels Mar 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1983080724

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.463%
Totals Coverage Status
Change from base Build 1982291507: 0.0%
Covered Lines: 52331
Relevant Lines: 62700
💛 - Coveralls

@mergify mergify bot merged commit a7d66f9 into Qiskit:main Mar 14, 2022
@HuangJunye HuangJunye mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrison @coveralls @mtreinish