Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend VF2Layout with 2-qubit-noise-scoring #7722

Closed
wants to merge 7 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Mar 3, 2022

This PR allows the user to set a scoring function in VF2Layout. A new two_q_score fidelity approximation function suggested by @czachow in https://github.com/Qiskit/qiskit-terra/pull/5075/files#diff-962c8087c2dc22fc3a88cc625c7fce565659b0c753ad21e0b8ccac0fa06a6249 was added.

  • More testing
  • Reno

@coveralls
Copy link

coveralls commented Mar 3, 2022

Pull Request Test Coverage Report for Build 1975650525

  • 33 of 36 (91.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 83.46%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/transpiler/passes/layout/vf2_layout.py 33 36 91.67%
Totals Coverage Status
Change from base Build 1969439195: 0.005%
Covered Lines: 52414
Relevant Lines: 62801

💛 - Coveralls

Co-authored-by: youngseok-kim1 <[email protected]>
@1ucian0 1ucian0 modified the milestones: 0.20, 0.19.3 Mar 8, 2022
@mtreinish
Copy link
Member

You might want to take a look at: #7776 I updated the heuristic layout scoring used by DenseLayout there to be general for all 2q and 1q operations in the target (I'm updating vf2layout to use a target in #7735 but I left adjusting the scoring for this PR). We can probably use some of the same heuristic here.

@1ucian0 1ucian0 modified the milestones: 0.20, 0.21 Mar 29, 2022
@mtreinish
Copy link
Member

I think we can close this as stale, I had to add approximate scoring that factored in 2 qubit error rates as part of #7862 and I just pushed up #7991 to unify the scoring between VF2PostLayout and VF2Layout.

@czachow
Copy link
Contributor

czachow commented Apr 28, 2022

Sounds good to me!

@1ucian0 1ucian0 closed this May 3, 2022
@1ucian0 1ucian0 deleted the 2q_score branch May 3, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants