-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TranspileErrors to routing passes for coupling_map=None #7141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbennet
changed the title
Adding TranspileErrors to routing passes when coupling_map=None
Add TranspileErrors to routing passes for coupling_map=None
Oct 15, 2021
Hello! This PR looks reasonable enough. Would you add a changelog item using |
Thanks @ecpeterson , changelog added. |
Pull Request Test Coverage Report for Build 4224614097
💛 - Coveralls |
HuangJunye
added
the
Community PR
PRs from contributors that are not 'members' of the Qiskit repo
label
Jun 21, 2022
mtreinish
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, it seems straightforward enough. Thanks for doing this and sorry that it fell through he cracks and took so long to review.
mtreinish
added
Changelog: Bugfix
Include in the "Fixed" section of the changelog
automerge
labels
Feb 20, 2023
Eric-Arellano
pushed a commit
to Eric-Arellano/qiskit-terra
that referenced
this pull request
Feb 23, 2023
) * Adding TranspileErrors to routing passes that run with coupling_map=None * Add changelog --------- Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the "Fixed" section of the changelog
Community PR
PRs from contributors that are not 'members' of the Qiskit repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request closes issue #7127 .
Details and comments
This PR adds TranspileErrors when routing passes attempt to run with coupling_map=None.
Example of such an error can be produced with the following snippet:
Catches added for
StochasticSwap
,SabreSwap
,LookaheadSwap
, andBasicSwap
.