Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix issue #6185 #7100

Closed
wants to merge 2 commits into from
Closed

Conversation

javabster
Copy link
Contributor

@javabster javabster commented Oct 5, 2021

Summary

fixes #6185, depends on #6883

Replaces valid_layers with a _get_gate_instance function that iterates over all gates in standard library

Details and comments

To do:

  • twolocal should throw error for multi-controlled gates
  • should the rotation layer blocks only support single qubit gates? The two_local docstring says The rotation layers are single qubit gates applied on all qubits but even in main branch you can set rotation_blocks="cx" and it will work

@javabster javabster changed the title Fix issue #6185 [WIP] Fix issue #6185 Oct 11, 2021
@Cryoris
Copy link
Contributor

Cryoris commented Nov 21, 2024

This is superseded by #12009 -- thanks for the effort nevertheless! 🙂

@Cryoris Cryoris closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in TwoLocal(..., entanglement_blocks=...)
2 participants