Revert "Add ESP readout support to Qiskit (#6543)" #6573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes made in Qiskit#6543 were unecessary and add ibm backend specific options to common interfaces in terra. This commit reverts Qiskit#6543 so it can be isolated to just the ibmq provider as the new options added in it are not common to all providers and isolated to just ibm backends. The changes made in Qiskit#6543 should have been done directly in the ibm provider and no changes to terra are actually needed here. Terra already provides all the functionality to enable the provider to add custom options like this. A provider can advertise the new run time option via the backend's `Options` object, expose the backend configuration option as a custom attribute at construction time, and pass the setting from the options to assemble so it gets set in the qobj config appropriately without requiring any changes from terra. However, this isn't all necessarily clear as the interface for `BackendV1` was primarily inherited from `BaseBackend` which didn't have this level of flexibility and doesn't make the distinction between required, optional, and custom options and backend attributes super clear. This is something we can hopefully address in the next version of the backend interface `BackendV2` (ideas for this are being collected in Qiskit#5885). This reverts commit 6d605a0.
|
I agree that the overall right approach is what you propose @mtreinish. If you believe the current approach is sufficiently incorrect that we must revert the changes we will. I will note that this work is critical to the QV64/128 release milestone and will have to make its way into the provider quickly to make this release date. It could be argued that the existing solution is sufficiently workable to not warrant a reversion given the circumstances. If we do make this reversion @zachschoenfeld33 will have to find a way to integrate into the unit test framework of the provider. |
|
If we need to revert, I am working w/ @jyu00 to put the check in the provider... |
taalexander
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The changes made in #6543 were unecessary and add ibm backend specific
options to common interfaces in terra. This commit reverts #6543 so it
can be isolated to just the ibmq provider as the new options added in
it are not common to all providers and isolated to just ibm backends.
The changes made in #6543 should have been done directly in the ibm
provider and no changes to terra are actually needed here. Terra already
provides all the functionality to enable the provider to add custom options
like this. A provider can advertise the new run time option via the
backend's
Optionsobject, expose the backend configuration option asa custom attribute at construction time, and pass the setting from the
options to assemble so it gets set in the qobj config appropriately
without requiring any changes from terra. However, this isn't all
necessarily clear as the interface for
BackendV1was primarilyinherited from
BaseBackendwhich didn't have this level of flexibilityand doesn't make the distinction between required, optional, and custom
options and backend attributes super clear. This is something we can
hopefully address in the next version of the backend interface
BackendV2(ideas for this are being collected in #5885).Details and comments
This reverts commit 6d605a0.