Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support on QuantumInstance/run_circuits for Backends that don't handle QasmQobj (backport #6299) #6343

Merged
merged 4 commits into from
May 3, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 3, 2021

This is an automatic backport of pull request #6299 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

…andle QasmQobj (#6299)

* Support BackendV1

* Add error mitigation logic.
Co-authored-by: Matthew Treinish <[email protected]>

* Fix run_circuits calls

* add unit tests

* Update qiskit/utils/run_circuits.py

Add check for providers that don't support it.

Co-authored-by: Matthew Treinish <[email protected]>

* Add error mitigation test

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit a0ed7ff)
@mergify mergify bot requested review from manoelmarques, woodsp-ibm and a team as code owners May 3, 2021 17:12
mtreinish
mtreinish previously approved these changes May 3, 2021
@mtreinish mtreinish added automerge Changelog: Bugfix Include in the "Fixed" section of the changelog labels May 3, 2021
2 of the tests added in #6299 depend on the fake backends in
qiskit.test.mock being strict BackendV1 backends (that reject qobj) and
also having other aspects of the interface implemented (mainly run
kwargs). However the change which updated the fake backends to use
BackendV1 (#6286) is not backportable as it's an API change, so these
tests are runnable in stable/0.17. This commit just removes these tests
because even if we could get them running without #6286 we wouldn't be
actually testing the v1 interface (which is their purpose).
mtreinish
mtreinish previously approved these changes May 3, 2021
manoelmarques
manoelmarques previously approved these changes May 3, 2021
@mtreinish mtreinish dismissed stale reviews from manoelmarques and themself via d083e73 May 3, 2021 18:56
@mergify mergify bot merged commit e73b3c6 into stable/0.17 May 3, 2021
@mergify mergify bot deleted the mergify/bp/stable/0.17/pr-6299 branch May 3, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants