Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IBMQ_guadalupe as a mock backend #6265

Merged
merged 4 commits into from
Apr 24, 2021
Merged

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Apr 20, 2021

IBMQ Guadalupe is a 16-qubit falcon processor.

@1ucian0 1ucian0 requested a review from a team as a code owner April 20, 2021 16:22
@kdk kdk added the automerge label Apr 23, 2021
@mergify mergify bot merged commit bb21d85 into Qiskit:main Apr 24, 2021
from qiskit.test.mock.fake_backend import FakeBackend


class FakeGuadalupe(FakeBackend):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a base class that should be used directly here, instead you should have used qiskit.test.mock.fake_pulse_backend.FakePulseBackend and then just defined the class attributes for the filenames.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks. I'll submit a follow up.

Copy link
Member

@mtreinish mtreinish Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I've got it covered as partof a larger refactor in #6286

@1ucian0 1ucian0 added the Changelog: New Feature Include in the "Added" section of the changelog label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants