Code

Support frames using signals#5977

Code

Closed

eggerdj wants to merge 119 commits intoQiskit:mainQiskit/qiskit:mainfrom eggerdj:support_frames_signalsCopy head branch name to clipboard

+1,837-217

Commits

Commits on Mar 5, 2021

• * First implementation of Frame.

  eggerdj

  committed
  23dbc67

• * Added an implementation of Signal, i.e. a Pulse in a Frame.

  eggerdj

  committed
  13cd3be

• * Added trackers to help resolve frames.

  eggerdj

  committed
  8f9fe8c

• * Added __init__ files.

  eggerdj

  committed
  306ac10

• * Added ignore_frames argument to the right and left alignment contexts in the builder.

  eggerdj

  committed
  7990fdd

• * Added frames configuration to the assembler.

  eggerdj

  committed
  280669a

• * Added call to frame resolution methodology in the assembler.

  eggerdj

  committed
  e0d2aac

• * Added frame resolution methodology in transforms.

  Show description for bb79fcb
  eggerdj

  committed
  bb79fcb

• * Added the frames function to the backend configuration.

  eggerdj

  committed
  70df612

• * Added changes to instructions to support Frames and Signals.

  eggerdj

  committed
  0db5c8d

Commits on Mar 8, 2021

• * Fixed issue in the way non-frame Shift/Set instructions are handled in resolve_frames.

  eggerdj

  committed
  8163f39

• * Added code to serialize frames config in the assembler.

  Show description for 6e91e95
  eggerdj

  committed
  6e91e95

• * Lint fix.

  eggerdj

  committed
  a38eb73

• * Lint fixes.

  eggerdj

  committed
  175d037

• * Lint fix.

  eggerdj

  committed
  597181f

Commits on Mar 9, 2021

• Merge branch 'master' of github.com:Qiskit/qiskit-terra into support_frames_signals

  eggerdj

  committed
  e9512e7

• * Added methodology to track the phase accumulation.

  eggerdj

  committed
  0a83f72

Commits on Mar 10, 2021

• * Added type hint to builder.

  Show description for 3506063
  eggerdj

  committed
  3506063

• * Tests for frame resolving and phase advance calculations.

  eggerdj

  committed
  81da036

• * Added a few more basic tests.

  eggerdj

  committed
  0f35a0e

• * Fixed bug in transforms.resolve_frames.

  eggerdj

  committed
  c510dc4

• * Lint fix.

  eggerdj

  committed
  23ee452

• * Fix lint.

  eggerdj

  committed
  fc30007

• * Fix cyclic import.

  eggerdj

  committed
  260fcbf

• * Lint fix.

  eggerdj

  committed
  d452e27

Commits on Apr 2, 2021

• * Merge branch 'master' of github.com:Qiskit/qiskit-terra into support_frames_signals

  Show description for 0f669c4
  eggerdj

  committed
  0f669c4

Commits on Apr 5, 2021

• * Fixed imports and refactored chan to the right location.

  eggerdj

  committed
  2aa651c

• * Added property to Signal.parameters

  eggerdj

  committed
  f1bfede

• * Made the handeling of parameters in ResolvedFrame consistent with the new methodology.

  eggerdj

  committed
  5fab67e

• * Added ignore_frames back to alignments as it was lost during merging of master.

  eggerdj

  committed
  1d34642

• * Aligned Signal and Frame to the ParameterManager functionality of pulse.

  Show description for 2c9e834
  eggerdj

  committed
  2c9e834

• * Fixed lint.

  eggerdj

  committed
  9843f88

• * Fixed test.

  eggerdj

  committed
  9410ca4

Commits on Apr 6, 2021

• * Added a warning to the builder.

  eggerdj

  committed
  028e9df

Commits on Apr 7, 2021

• * Removed is parameterized from Frame and self._parameters.

  eggerdj

  committed
  a38e029

• * Moved hash generation in Frame to constructor.

  eggerdj

  committed
  2d39fe1

• * Moved validate_index from channels and frame to utils.

  eggerdj

  committed
  cae1aff

• Update qiskit/pulse/library/signal.py

  Show description for a41148c
  

  eggerdj

  and

  nkanazawa1989

  authored
  a41148c

• * Fixed docstring.

  eggerdj

  committed
  fdf6852

• * Removed id from Signal.

  Show description for e419714
  eggerdj

  committed
  e419714

• * Used validate_index in parameter manager.

  eggerdj

  committed
  b392d1e

• * Improved validate_index usage in parameter manager.

  eggerdj

  committed
  3e46388

• Update qiskit/pulse/transforms/frames.py

  Show description for 7ece5ae
  

  eggerdj

  and

  nkanazawa1989

  authored
  7ece5ae

• Update qiskit/pulse/builder.py

  Show description for 858e136
  

  eggerdj

  and

  lcapelluto

  authored
  858e136

• Update qiskit/pulse/transforms/alignments.py

  Show description for 7ec977d
  

  eggerdj

  and

  lcapelluto

  authored
  7ec977d

• Update qiskit/pulse/resolved_frame.py

  Show description for b7bc92f
  

  eggerdj

  and

  lcapelluto

  authored
  b7bc92f

Commits on Apr 8, 2021

• * Moved resolved_frame.py to transforms.

  eggerdj

  committed
  dfc6971

• Merge branch 'support_frames_signals' of github.com:eggerdj/qiskit-terra into support_frames_signals

  eggerdj

  committed
  6297a24

• * Removed parameters from ResolvedFrame.

  eggerdj

  committed
  b66e192

• * Renamed sample_duration to dt.

  eggerdj

  committed
  b365e30

• * Added numerical threshhold.

  eggerdj

  committed
  46623d8

• * Added raise on unsupported instructions in frames resolution.

  eggerdj

  committed
  b604ee1

• * Improved docstring.

  eggerdj

  committed
  eae9f3e

• * Changed frames_config to have the frame as key.

  eggerdj

  committed
  cf82c2b

• * Cleaned up index notation.

  eggerdj

  committed
  46292e9

• * Fixed docstring.

  eggerdj

  committed
  6332748

• * Fixed comment.

  eggerdj

  committed
  94a8cd7

• * Removed _frequency and _phase from ChannelTracker.

  Show description for fdb1792
  eggerdj

  committed
  fdb1792

• * Improved code efficient in resolved frame.

  eggerdj

  committed
  8f6d1fc

• * Cleaned-up transforms.frames.py.

  eggerdj

  committed
  a785b7c

• * Changed operands[0] -> pulse.

  eggerdj

  committed
  a1b160d

• * Improved documentation of tests.

  eggerdj

  committed
  b32ff06

Commits on Apr 9, 2021

• Update qiskit/pulse/transforms/resolved_frame.py

  Show description for 8c710ac
  

  eggerdj

  and

  lcapelluto

  authored
  8c710ac

• * Moved to assertTrue.

  eggerdj

  committed
  399fce4

Commits on May 31, 2021

• Merge branch 'main' of github.com:Qiskit/qiskit-terra into support_frames_signals

  eggerdj

  committed
  16fa292

• * Fix issues from merging.

  eggerdj

  committed
  4674648

• * Black.

  eggerdj

  committed
  27dc741

Commits on Jun 11, 2021

• Merge branch 'main' into support_frames_signals

  eggerdj

  authored
  aff1c6b

• * Made frame take a string identifier and optional parameter.

  eggerdj

  committed
  a7ae702

• * Changed the backend configuration.

  eggerdj

  committed
  d8aa27f

• * Refactored the frames config.

  eggerdj

  committed
  31c31c3

• * Refactored ResolvedFrame.

  eggerdj

  committed
  5814d37

• * Improved parameter treatment in frame.

  eggerdj

  committed
  92d40b9

• * Removed frame channels in transforms.

  eggerdj

  committed
  f9c90e5

• * Amend assemble_schedule.

  eggerdj

  committed
  b5641d3

Commits on Jun 14, 2021

• * Align and refactor tests.

  eggerdj

  committed
  5a9ccd3

• * Black.

  eggerdj

  committed
  75cfac7

• * Caught an edge case.

  eggerdj

  committed
  edf2510

• * Removed a bug that came from a merge issue.

  eggerdj

  committed
  b736a91

• Merge branch 'main' into support_frames_signals

  eggerdj

  authored
  85f466a

• * Lint.

  eggerdj

  committed
  f3fbbd8

• Merge branch 'support_frames_signals' of github.com:eggerdj/qiskit-terra into support_frames_signals

  eggerdj

  committed
  8622353

Commits on Jun 15, 2021

• * Removed unused variable in test.

  eggerdj

  committed
  7b2b25f

Commits on Jun 22, 2021

• * Added a data class in resolved_frame-py.

  eggerdj

  committed
  bff077f

• * Added property Signal to Play.

  Show description for d51d2d0
  eggerdj

  committed
  d51d2d0

• * Improved set_phase and set_frequency in resolved_frame.py.

  eggerdj

  committed
  31ef605

• * Minor bug fix.

  eggerdj

  committed
  59d2d99

• * Resolved frame now sorts in reversed order.

  Show description for b7e8b40
  eggerdj

  committed
  b7e8b40

• * Added a FramesConfiguration class.

  eggerdj

  committed
  252e1fb

• * Tighter integration between FrameDefintion, FramesConfig, and ResolvedFrame.

  eggerdj

  committed
  c9afa47

• * Added a clear distinction between prefix and index in Frame.

  eggerdj

  committed
  ff44ff8

• * Moved frame resolution to base_transforms.py.

  eggerdj

  committed
  582fdaf

• * Made the tolerance in frames resolution configurable.

  eggerdj

  committed
  9927f80

Commits on Jun 25, 2021

• * Added a method to add dt to FramesConfiguration.

  eggerdj

  committed
  14efefa

• * Made frames property mutable.

  eggerdj

  committed
  e14fbca

• * Changed location in assemble where dt is added.

  eggerdj

  committed
  ee161ee

• * Frame is no longer optional in signal.

  eggerdj

  committed
  e849758

• * Changed prefixes for pulse defautl frames.

  Show description for 5ec2682
  eggerdj

  committed
  5ec2682

• * Refactored sample_duration.

  eggerdj

  committed
  990eec5

Commits on Jun 26, 2021

• * Added method to simultaneously set frequency and phase in the Tracker.

  eggerdj

  committed
  7fe2b3a

• * Fix tests.

  eggerdj

  committed
  ba56563

• * Improved documentation for the frames config.

  eggerdj

  committed
  cf319f2

Commits on Jun 27, 2021

• * Pop the frames config from the qobj_config.

  eggerdj

  committed
  b8aa3ba

• * Added condition to see if frames need resolving.

  eggerdj

  committed
  282e4a5

• * Added frames config to the common args.

  eggerdj

  committed
  96d205c

• * Added assembly tests.

  eggerdj

  committed
  d98288c

• * Added frames config bug fix in transforms.

  eggerdj

  committed
  c9eee29

• * Added condition to catch frame instructions in resolve.

  eggerdj

  committed
  f10a8ab

• * Shift and Set instructions now only use frames. Channels are still supported for backward compatibility.

  eggerdj

  committed
  df7ac4e

Commits on Jun 29, 2021

• * Frame of channel can no longet be set by user.

  eggerdj

  committed
  d18ba34

• * Instructions have a frames property.

  Show description for 121fcb7
  eggerdj

  committed
  121fcb7

• * Renamed resolve_frames to map_frames.

  Show description for 378a768
  eggerdj

  committed
  378a768

• * Added raise for calibrations that require frame mapping.

  eggerdj

  committed
  2b738df

• * Refactored set_frame_instructions.

  Show description for 02a9f21
  eggerdj

  committed
  02a9f21

• * Black.

  eggerdj

  committed
  7f897fb

• Merge branch 'main' into support_frames_signals

  eggerdj

  authored
  b639ba2

Commits on Jul 2, 2021

• * Refactor of frames.

  eggerdj

  committed
  7650f81

• * Simplified channel tracking by removing the initialization.

  eggerdj

  committed
  71b51d3

Commits on Jul 3, 2021

• * Made mapping cleaner.

  eggerdj

  committed
  7ce6add