-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speeling fixes #5858
speeling fixes #5858
Conversation
I like that your commit says "speeling fixes" ;) |
Nice - we had spelling running on Aqua since the docstrings end up as the published documentation it made sense to us to fix them in build. I note you changed In your exception list you have |
Yeah it would be nice to get to the point to turn it on by default, but the pylint spelling checker is fairly unintelligent and for example doesn't add the names that are in scope locally to the wordlist, doesn't ignore sphinx directives, inline tex, etc. Don't want to discourage contributors from writing more docstrings by making them fight with pylint.
Parametrize{,d} looked so obviously wrong to me I didn't even think to check... Seems like both are used, but parameterize is quite a bit more common.
My schooling coming through there. Probably best to go all US. |
On the other hand we already have (favoured internationally) |
* speeling fixes * lint * pylint-spelling partial enable * UK->US Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* speeling fixes * lint * pylint-spelling partial enable * UK->US Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* speeling fixes * lint * pylint-spelling partial enable * UK->US Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fixed a bunch of typos.
Added a local wordlist and pylint spelling configuration - makes it a little less noisy, but far from quiet enough to enable by default.