-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScheduleBlock 2/4 - add Call instruction #5781
Merged
mergify
merged 84 commits into
Qiskit:master
from
nkanazawa1989:issue-5679-2_schedule_block
Feb 25, 2021
Merged
ScheduleBlock 2/4 - add Call instruction #5781
mergify
merged 84 commits into
Qiskit:master
from
nkanazawa1989:issue-5679-2_schedule_block
Feb 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Alexander <[email protected]>
Co-authored-by: Thomas Alexander <[email protected]>
Co-authored-by: Lauren Capelluto <[email protected]>
…9/qiskit-terra into issue-5679-1_schedule_block
…79-2_schedule_block
Thanks, I updated docstrings accordingly, and updated the logic of call function. Now we can handle parameters as kwargs at the builder level, i.e. with pulse.build() as sched:
pulse.call(subroutine, amp=0.1, sigma=40, ...) |
…9/qiskit-terra into issue-5679-2_schedule_block
taalexander
requested changes
Feb 17, 2021
@taalexander Thanks! I updated parameter handling based on your suggestion. |
taalexander
reviewed
Feb 18, 2021
taalexander
approved these changes
Feb 25, 2021
eggerdj
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is 2/4 step of
ScheduleBlock
implementation #5679Details and comments
This PR adds
Call
instruction to pulse instruction set. This instruction is not exposed to end users. However, it implicitly wraps schedules or circuits whenpulse.call
function is used within the pulse builder context. TheCall
instruction explicitly defines a subroutine that is defined outside of the current scope, thus the Qiskit compiler will be able to generate better target code, i.e. the compiler can avoid defining duplicated subprograms multiple times. The logic of the pulse builder is slightly updated to introduce this instruction.