-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get jobs from IBM Q backend #501
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
bcac889
job cancellation improvements for hubs
ewinston cd825f4
add alternate ibmqjob init method; from_api()
ewinston 93aa378
add retrieve_job for ibmq backends
ewinston 3df6680
add name to pre-qobj job submission
ewinston e00a1b5
fix bug in ibmq job submission
ewinston a49ea94
add circuit names to non-qobj ibmq job submission
ewinston 5909a0d
remove qobj from result
ewinston f4e9898
add temporary hack for bit reordering
ewinston 5a77bd9
remove qobj keyword from ibmqjob.result()
ewinston 641becc
changed job timer.
ewinston 8284926
linting
ewinston a72d9ec
simplify import of JobStatus
ewinston f437e0a
dissallow += results from different backends
ewinston 3d5904e
moved JobStatus to it's own file.
ewinston c9fb95f
bug fix
ewinston 97abf82
linting
ewinston 0afb90d
fix bug in backend.jobs
ewinston 7516e7a
allow retrieving old jobs without metadata
ewinston 674af67
minor improvement to backend.jobs
ewinston 2b79d6b
linting
ewinston 0cfd4cb
speed up backend.jobs(). job_id->id
ewinston 00cd596
linting
ewinston d7d1a4f
incorporating some suggestions from @atilag
ewinston 10d0bc2
improvements to ibmqjob.status
ewinston 2e72457
linting
ewinston 49edb41
linting
ewinston 8581dcb
linting
ewinston 11d859b
update job status_msg
ewinston a426d1b
fix hanging job.status on server error
ewinston c2d1033
remove job status filtering
ewinston cee799c
linting
ewinston 13274e6
Merge branch 'master' into backend_jobs
atilag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now that
Result._qobj
is removed, we can unpackResult._result
, and not have so many levels of indirection. That means havingResult._job_id
,Result._status
,Result._result
, where the latter contains all the data.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can leave this for a subsequent PR since it's not directly related to this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think we should leave this, also because it's not clear how qobj and result may be represented together later.
I think the most important thing in this PR is to not give errors when
metadata
is unavailable from a past job.