-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back repr for Result and related classes #4987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the removal of marshmallow from the Result class (and terra as a whole) in Qiskit#4030 the descriptive repr for the objects was lost. This is inconvenient because the default representation for an object is just the class name and the memory address of the object. This commit adds back a string representation of the objects which were missing by adding a __repr__ method to the classes.
If people are curious an example output from
|
1ucian0
reviewed
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add a test for this?
I can, but it's not like it's a critical piece it's just a string representation of the data in there. |
ajavadia
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the removal of marshmallow from the Result class (and terra as a
whole) in #4030 the descriptive repr for the objects was lost. This is
inconvenient because the default representation for an object is just
the class name and the memory address of the object. This commit adds
back a string representation of the objects which were missing by adding
a repr method to the classes.
Details and comments