Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BasisTranslator and UnrollCustomDefinitions passes. #4442

Merged
merged 4 commits into from
May 23, 2020

Conversation

kdk
Copy link
Member

@kdk kdk commented May 13, 2020

Adds BasisTranslator and UnrollCustomDefinition passes from Qiskit/RFCs#6 . UnrollCustomDefinitions unrolls all instructions in the circuit according to their .definition property, stopping when reaching either the specified basis_gates or a set of gates in the provided EquivalenceLibrary. BasisTranslator searches over the set of translations in the provided EquivalenceLibrary to re-write circuit instructions in a specified basis.

on-hold for #4431 .

@kdk kdk added the on hold Can not fix yet label May 13, 2020
@kdk kdk added this to the 0.15 milestone May 13, 2020
@kdk kdk force-pushed the add-basistranslator-pass branch from 3a6b7d9 to fae8e9a Compare May 13, 2020 16:15
@kdk kdk added the Changelog: New Feature Include in the "Added" section of the changelog label May 13, 2020
@kdk kdk force-pushed the add-basistranslator-pass branch from 3f3f245 to b91aa9d Compare May 13, 2020 21:13
@kdk kdk removed the on hold Can not fix yet label May 13, 2020
@kdk kdk force-pushed the add-basistranslator-pass branch from b91aa9d to edb8ca4 Compare May 13, 2020 21:57
Copy link
Member

@ajavadia ajavadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good i left some comments

qiskit/transpiler/passes/__init__.py Show resolved Hide resolved
qiskit/transpiler/passes/basis/basis_translator.py Outdated Show resolved Hide resolved
test/python/transpiler/test_basis_translator.py Outdated Show resolved Hide resolved
test/python/transpiler/test_basis_translator.py Outdated Show resolved Hide resolved
qiskit/transpiler/passes/basis/basis_translator.py Outdated Show resolved Hide resolved
@kdk kdk force-pushed the add-basistranslator-pass branch from edb8ca4 to a11fb98 Compare May 19, 2020 21:44
@kdk kdk requested a review from a team as a code owner May 19, 2020 21:44
@kdk kdk force-pushed the add-basistranslator-pass branch from a11fb98 to 9724d56 Compare May 21, 2020 21:01
@ajavadia ajavadia merged commit 8756861 into Qiskit:master May 23, 2020
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
* Add UnrollCustomDefinitions pass.

* Add BasisTranslator pass.

* Remove outdated unroller test.

Co-authored-by: Ali Javadi-Abhari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants