-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BasisTranslator and UnrollCustomDefinitions passes. #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdk
requested review from
1ucian0,
ajavadia,
chriseclectic,
DanPuzzuoli,
eggerdj,
ewinston,
itoko,
jaygambetta,
jyu00,
lcapelluto,
maddy-tod,
mtreinish,
nkanazawa1989,
nonhermitian and
taalexander
as code owners
May 13, 2020 15:25
kdk
force-pushed
the
add-basistranslator-pass
branch
from
May 13, 2020 16:15
3a6b7d9
to
fae8e9a
Compare
kdk
added
the
Changelog: New Feature
Include in the "Added" section of the changelog
label
May 13, 2020
kdk
force-pushed
the
add-basistranslator-pass
branch
from
May 13, 2020 21:13
3f3f245
to
b91aa9d
Compare
kdk
force-pushed
the
add-basistranslator-pass
branch
from
May 13, 2020 21:57
b91aa9d
to
edb8ca4
Compare
ajavadia
reviewed
May 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good i left some comments
kdk
force-pushed
the
add-basistranslator-pass
branch
from
May 19, 2020 21:44
edb8ca4
to
a11fb98
Compare
kdk
force-pushed
the
add-basistranslator-pass
branch
from
May 21, 2020 21:01
a11fb98
to
9724d56
Compare
ajavadia
approved these changes
May 23, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* Add UnrollCustomDefinitions pass. * Add BasisTranslator pass. * Remove outdated unroller test. Co-authored-by: Ali Javadi-Abhari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds BasisTranslator and UnrollCustomDefinition passes from Qiskit/RFCs#6 .
UnrollCustomDefinitions
unrolls all instructions in the circuit according to their.definition
property, stopping when reaching either the specifiedbasis_gates
or a set of gates in the providedEquivalenceLibrary
.BasisTranslator
searches over the set of translations in the providedEquivalenceLibrary
to re-write circuit instructions in a specified basis.on-hold for #4431 .