Issue #4182 Initializer should use at most 2^(n+1)-2n cnots #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjs
requested review from
1ucian0,
ajavadia,
ewinston,
kdk and
mtreinish
as code owners
|
As far as I recall, both these optimizations were implemented three years ago. EDIT: Oops, I relooked at the paper and see that I missed this optimization. Indeed a version of this optimization was implemented within a multiplexed Rz or Ry call, but the paper shows that the same optimization can be made between two "neighbouring" multiplexed Rz and Ry calls. Thank you for spotting this. |
Cryoris
reviewed
May 4, 2020
Cryoris
approved these changes
May 4, 2020
There was a problem hiding this comment.
LGTM, I think for @ismaila-at-za-ibm as well as from the comment above. @ajavadia or @kdk could you have a final look and approve if it is alright for you?
ajavadia
approved these changes
Jun 18, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…skit#4183) * reverse multiplexed Ry * simplifying cnots * simplifying cnots * simplify last cnot * test initializer number of cnots * fix style * numbers which test failed for the old implementation Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mtreinish
added
the
Changelog: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4182 Initializer should use at most$2^(n+1)$ -2n cnots
Details and comments
Optimizations described in arXiv:quant-ph/0406176