Remove pformat from stochastic swap log messages #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
requested review from
1ucian0,
ajavadia,
itoko and
kdk
as code owners
When profiling a level 0 transpile of a 20x50 random circuit the timing data shows that after switching to retworkx the largest chunk of time in in stochastic swap's _layer_permutation function is spent calling pformat for log messages. This is just for debugging and is unecessary, and in a world where we're no longer bottlenecked on dag operations a signifcant cost to the run time.
|
Here is the profiling data I was looking at:
You can see |
|
This is only really needed after #3810 Without that pr this is still a good fix but really a micro optimization because the dag operations using networkx are significantly slower than anything in stochastic swap. |
ajavadia
approved these changes
Feb 11, 2020
kdk
approved these changes
Feb 11, 2020
|
Just circling back for completeness now that's this merged running another profile graph with #3810 applied with this merged shows:
We can't see the formatting in the string anymore and also stochastic swap's layer permutation no longer is the slowest function:
|
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
When profiling a level 0 transpile of a 20x50 random circuit the timing data shows that after switching to retworkx the largest chunk of time in in stochastic swap's _layer_permutation function is spent calling pformat for log messages. This is just for debugging and is unecessary, and in a world where we're no longer bottlenecked on dag operations a signifcant cost to the run time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When profiling a level 0 transpile of a 20x50 random circuit the timing
data shows that after switching to retworkx the largest chunk of time in
in stochastic swap's _layer_permutation function is spent calling pformat
for log messages. This is just for debugging and is unnecessary, and in a
world where we're no longer bottle-necked on dag operations a significant
cost to the run time.
Details and comments