Deprecate passing in an ast node as a instruction parameter #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deprecates the option of passing in a circuit parameter of a qasm.node.Node type. Passing in qasm ast nodes as a parameter is rarely used and is not actually done anywhere in the qiskit-terra code or tests. Additionally there is the qiskit ast_to_circuit converter which will take a program node object (the root node of a qasm ast) and convert that directly to a circuit object.
mtreinish
added
the
Changelog: Deprecation
mtreinish
requested review from
1ucian0,
ajavadia,
ewinston and
kdk
as code owners
kdk
approved these changes
Oct 11, 2019
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
) This commit deprecates the option of passing in a circuit parameter of a qasm.node.Node type. Passing in qasm ast nodes as a parameter is rarely used and is not actually done anywhere in the qiskit-terra code or tests. Additionally there is the qiskit ast_to_circuit converter which will take a program node object (the root node of a qasm ast) and convert that directly to a circuit object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit deprecates the option of passing in a circuit parameter of
a qasm.node.Node type. Passing in qasm ast nodes as a parameter is
rarely used and is not actually done anywhere in the qiskit-terra code
or tests. Additionally there is the qiskit ast_to_circuit converter
which will take a program node object (the root node of a qasm ast) and
convert that directly to a circuit object.
Details and comments