Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions, options, and behavior from circuit_drawer #1567

Merged

Conversation

mtreinish
Copy link
Member

Summary

In the 0.7 release we deprecated several functions, options, and
behaviors in the circuit drawers. Now that we've got that release out
the door we can stage the removal of those things. This commit does that
and removes all the things we deprecated to stage for removal in the
circuit drawers.

Details and comments

In the 0.7 release we deprecated several functions, options, and
behaviors in the circuit drawers. Now that we've got that release out
the door we can stage the removal of those things. This commit does that
and removes all the things we deprecated to stage for removal in the
circuit drawers.
@diego-plan9
Copy link
Member

We tend to fully deprecate near the end of a major release (ie. in this case, when 0.8 is published), to give enough leeway to users and also taking into account that minor releases (0.7.1, etc) might happen in the meantime, sometimes in short spans. Do we really want to modify that convention in this particular case?

@mtreinish
Copy link
Member Author

We tend to fully deprecate near the end of a major release (ie. in this case, when 0.8 is published), to give enough leeway to users and also taking into account that minor releases (0.7.1, etc) might happen in the meantime, sometimes in short spans. Do we really want to modify that convention in this particular case?

That doesn't make any sense to me. If we treated master that way we'd never be able to land new features or any other potentially breaking change. If we need to do a point release for a bugfix that's why we have the stable branch right? We'll have to port the patches for a point release to that branch. Either we open master for 0.8 development or we don't. The intent with these deprecations was to always remove them post 0.7 and if we've really opened 0.8 development on master then there is no reason to wait. I'd rather not keep around code we're not supporting and clean things up sooner, especially before we make any bigger changes in the near future.

@jaygambetta
Copy link
Member

jaygambetta commented Dec 27, 2018

@mtreinish and @diego-plan9 im good to start doing this now. We should only use 0.7.1 to fix bug and patches.

@diego-plan9
Copy link
Member

Ok - created #1646 for keeping track.

@jaygambetta
Copy link
Member

@mtreinish can you fix the linter errors

@jaygambetta jaygambetta merged commit 91717f6 into Qiskit:master Jan 5, 2019
@mtreinish mtreinish deleted the remove-deprecated-circuit-drawers branch January 5, 2019 06:01
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
Qiskit#1567)

* Remove deprecated functions, options, and behavior from circuit_drawer

In the 0.7 release we deprecated several functions, options, and
behaviors in the circuit drawers. Now that we've got that release out
the door we can stage the removal of those things. This commit does that
and removes all the things we deprecated to stage for removal in the
circuit drawers.

* Fix test imports

* Fix whitespace

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants