-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated functions, options, and behavior from circuit_drawer #1567
Remove deprecated functions, options, and behavior from circuit_drawer #1567
Conversation
In the 0.7 release we deprecated several functions, options, and behaviors in the circuit drawers. Now that we've got that release out the door we can stage the removal of those things. This commit does that and removes all the things we deprecated to stage for removal in the circuit drawers.
We tend to fully deprecate near the end of a major release (ie. in this case, when |
That doesn't make any sense to me. If we treated master that way we'd never be able to land new features or any other potentially breaking change. If we need to do a point release for a bugfix that's why we have the stable branch right? We'll have to port the patches for a point release to that branch. Either we open master for 0.8 development or we don't. The intent with these deprecations was to always remove them post 0.7 and if we've really opened 0.8 development on master then there is no reason to wait. I'd rather not keep around code we're not supporting and clean things up sooner, especially before we make any bigger changes in the near future. |
@mtreinish and @diego-plan9 im good to start doing this now. We should only use 0.7.1 to fix bug and patches. |
Ok - created #1646 for keeping track. |
@mtreinish can you fix the linter errors |
Qiskit#1567) * Remove deprecated functions, options, and behavior from circuit_drawer In the 0.7 release we deprecated several functions, options, and behaviors in the circuit drawers. Now that we've got that release out the door we can stage the removal of those things. This commit does that and removes all the things we deprecated to stage for removal in the circuit drawers. * Fix test imports * Fix whitespace * Fix lint
Summary
In the 0.7 release we deprecated several functions, options, and
behaviors in the circuit drawers. Now that we've got that release out
the door we can stage the removal of those things. This commit does that
and removes all the things we deprecated to stage for removal in the
circuit drawers.
Details and comments