Fix qpy serialization of substitution of type ParameterExpression (backport #13890)
#13943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…13890) * Fix qpy serialization of substitution of type ParameterExpression When substitution history `ParameterExpression._qpy_replay` is serialized, there was no branch for the case that the substituted value is of type `ParameterExpression`. This commit fixes this oversight. * Fix deserializing qpy written by previous writing fix * Added a branch for reading `ParameterExpression` in _qpy_replay * Added a missing argument (version) in an existing call in code path that was previously untested * Remove a bit of useless code introduced in last commit * run black * Add tests * Revert renaming extra_symbols to extra_expressions Reverting this to minimize changes in order to make the PR safer to backport. * Revert cleaning up logic in _encode_replay_subs This was a good change. But not necessary for the bug fix, which is the main point of this PR. * Add qpy compat test * Bind parameter when checking for equality * Run black after merge in browser --------- Co-authored-by: Luciano Bello <[email protected]> (cherry picked from commit a6fa6f8) # Conflicts: # test/qpy_compat/test_qpy.py
|
Cherry-pick of a6fa6f8 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mergify
bot
added
the
conflicts
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 13632006440Details
💛 - Coveralls |
ElePT
previously approved these changes
Mar 3, 2025
mtreinish
reviewed
Mar 3, 2025
ElePT
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When substitution history
ParameterExpression._qpy_replayis serialized, there was no branch for the case that the substituted value is of typeParameterExpression.This commit fixes this oversight.
Tests need to be added.Closes #13879
This is an automatic backport of pull request #13890 done by [Mergify](https://mergify.com).