-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate DAGCircuit.name
in ApplyLayout
(backport #13910)
#13920
Conversation
Cherry-pick of 29aa2bd has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
d11512f
to
a87fa39
Compare
Pull Request Test Coverage Report for Build 13525152901Details
💛 - Coveralls |
* Propagate `DAGCircuit.name` in `ApplyLayout` This has always been absent, but `transpile` masked the problem by assigning the output circuit names by overwriting the `output_names` input kwarg if it wasn't set. `generate_preset_pass_manager` didn't have the same logic, so it was observable that `ApplyLayout` didn't propagate the name. We could have added similar name-propagation logic to `generate_preset_pass_manager`, but really the bug is in `ApplyLayout`; passes _should_ propagate the metadata. * Fix typo Co-authored-by: John Lapeyre <[email protected]> * Remove redunant set --------- Co-authored-by: John Lapeyre <[email protected]> (cherry picked from commit 29aa2bd)
a87fa39
to
0be1080
Compare
This has always been absent, but
transpile
masked the problem by assigning the output circuit names by overwriting theoutput_names
input kwarg if it wasn't set.generate_preset_pass_manager
didn't have the same logic, so it was observable thatApplyLayout
didn't propagate the name.We could have added similar name-propagation logic to
generate_preset_pass_manager
, but really the bug is inApplyLayout
; passes should propagate the metadata.Summary
Details and comments
This is an automatic backport of pull request #13910 done by [Mergify](https://mergify.com).