Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Linux AArch64 wheels natively without QEMU (backport #13682) #13684

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 17, 2025

GitHub Actions now provides Linux runner images on native arm64 hardware1, which means we should be able to build the wheels natively, without requiring QEMU. This potentially paves the way (pending a more complete move of CI to GHA) for Linux on AArch64 to potentially gain Tier 1 platforma support.

Summary

Details and comments


This is an automatic backport of pull request #13682 done by [Mergify](https://mergify.com).

Footnotes

  1. https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

* Build Linux AArch64 wheels natively without QEMU

GitHub Actions now provides Linux runner images on native arm64
hardware[^1], which means we should be able to build the wheels natively,
without requiring QEMU.  This potentially paves the way (pending a more complete
move of CI to GHA) for Linux on AArch64 to potentially gain Tier 1
platforma support.

[^1]: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

* Remove restriction on tests

We previously restricted the tests to a small subset of the suite
because of runtime concerns with QEMU.  Since we are now running
natively, this removes the restriction, bringing Linux AArch64 in line
with what we expect from a Tier 2 platform.

* Remove explicit architecture selection

(cherry picked from commit 3150351)

# Conflicts:
#	.github/workflows/wheels-build.yml
@mergify mergify bot requested a review from a team as a code owner January 17, 2025 17:42
Copy link
Contributor Author

mergify bot commented Jan 17, 2025

Cherry-pick of 3150351 has failed:

On branch mergify/bp/stable/1.3/pr-13682
Your branch is up to date with 'origin/stable/1.3'.

You are currently cherry-picking commit 3150351f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/wheels-build.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Jan 17, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog ci: test wheels Run the wheel-build scripts as an additional CI run for this PR labels Jan 17, 2025
@jakelishman jakelishman removed the conflicts used by mergify when there are conflicts in a port label Jan 17, 2025
@jakelishman jakelishman enabled auto-merge January 17, 2025 18:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12834232159

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 88.927%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 93.21%
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 4 92.48%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 12818233781: 0.0%
Covered Lines: 79188
Relevant Lines: 89048

💛 - Coveralls

@jakelishman jakelishman removed the ci: test wheels Run the wheel-build scripts as an additional CI run for this PR label Jan 18, 2025
@jakelishman jakelishman added this pull request to the merge queue Jan 18, 2025
Merged via the queue into stable/1.3 with commit 6151f16 Jan 18, 2025
28 checks passed
@jakelishman jakelishman deleted the mergify/bp/stable/1.3/pr-13682 branch January 18, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants