Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply MCMT plugin on MCMTGate (backport #13596) #13618

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 7, 2025

Summary

Fixes #13563, by enabling the high-level synthesis plugins of MCMT only for the MCMTGate, not any gate called "mcmt".

Details and comments

While we often let it be the user's responsibility to be mindful with gate names, this is a special case as we provide a circuit called "mcmt". This can cause innocent-looking code to break, so we should add this check at least until the MCMT circuit is removed 🙂


This is an automatic backport of pull request #13596 done by [Mergify](https://mergify.com).

* Only apply MCMT plugin on MCMTGate

* add checks for other gates

* fix reno

* use == instead of equiv

(cherry picked from commit 0eeba0d)
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Jan 7, 2025
@github-actions github-actions bot added this to the 1.3.2 milestone Jan 7, 2025
@Cryoris Cryoris enabled auto-merge January 7, 2025 12:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12651367464

Details

  • 12 of 31 (38.71%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 88.934%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/transpiler/passes/synthesis/hls_plugins.py 12 31 38.71%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/hls_plugins.py 1 83.38%
crates/qasm2/src/lex.rs 7 91.98%
Totals Coverage Status
Change from base Build 12631844630: 0.01%
Covered Lines: 79161
Relevant Lines: 89011

💛 - Coveralls

@Cryoris Cryoris added this pull request to the merge queue Jan 7, 2025
Merged via the queue into stable/1.3 with commit 103b779 Jan 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants