Fix behavior of n_local calling circuits for num_qubits=1 (backport #13523) #13575
+56
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* added fix for efficient_su2 * making fix for real_amplitudes and excitation_preserving * formatted * passing tests * added release notes * fixed pauli_two_design * fixed format * fixed pauli_two_design issue * fixed unused gate * Update qiskit/circuit/library/n_local/pauli_two_design.py Co-authored-by: Julien Gacon <[email protected]> * addressing change --------- Co-authored-by: Julien Gacon <[email protected]> (cherry picked from commit 82bbcaa)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 12370640779Details
💛 - Coveralls |
ElePT
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13480.
When circuits that construct n_local were passed num_qubits = 1, an error would be thrown because the default entangling gate, "cx", requires at least 2. The fix involved just checking for num_qubits and setting to an empty array if num_qubits is not greater than 1.
Details and comments
The fix had to be applied to efficient_su2, excitation_preserving, and real_amplitudes. Test methods were added for each changed function.
This is an automatic backport of pull request #13523 done by [Mergify](https://mergify.com).