Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StabilizerState.expectation_value can also accept SparsePauliOp #13539

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ShellyGarion
Copy link
Member

Summary

close #12422

Details and comments

@ShellyGarion ShellyGarion added Changelog: New Feature Include in the "Added" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) labels Dec 8, 2024
@ShellyGarion ShellyGarion requested a review from a team as a code owner December 8, 2024 15:33
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Dec 8, 2024

Pull Request Test Coverage Report for Build 12374782380

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • 75 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.005%) to 88.955%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/quantum_info/states/stabilizerstate.py 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
qiskit/circuit/library/quantum_volume.py 1 93.18%
crates/accelerate/src/unitary_synthesis.rs 1 92.2%
qiskit/circuit/library/arithmetic/adders/adder.py 2 91.49%
crates/qasm2/src/parse.rs 6 97.62%
crates/qasm2/src/lex.rs 7 92.48%
crates/circuit/src/circuit_data.rs 19 95.43%
qiskit/transpiler/passes/synthesis/hls_plugins.py 39 87.02%
Totals Coverage Status
Change from base Build 12182055039: 0.005%
Covered Lines: 79431
Relevant Lines: 89293

💛 - Coveralls

)

else:
raise QiskitError(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeError might be more appropriate (but if this is Qiskit's convention then it's fine)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that also previously it was a QiskitError:

raise QiskitError("Operator for expectation value is not a Pauli operator.")

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny comments, otherwise LGTM 👍🏻

qiskit/quantum_info/states/stabilizerstate.py Outdated Show resolved Hide resolved
qiskit/quantum_info/states/stabilizerstate.py Outdated Show resolved Hide resolved
qiskit/quantum_info/states/stabilizerstate.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StabilizerState.expectation_value should accept SparsePauliOp
5 participants