Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
CircuitData
struct had twoimpl CircuitData
blocks, one before the pymethods and the other after. While there is nothing wrong with doing this it is a bit confusing because the difference between the blocks is not clear. I expect this was caused by the size of the file and people missed that it already existed and we ended up with duplicates. This commit recombines the two blocks, opting to use the one after the pymethods as it was larger.Details and comments