Use PyO3 0.22 and rust-numpy 0.22 #13313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates to using PyO3 0.22 and rust-numpy and updates all the deprecated and changed interfaces in the libraries to their new syntax. No new or alternative interfaces are used as part of this PR except for where deprecation warnings pointed to do so. One thing to note is that in pyo3 0.22 a new feature py-clone was added to re-enable `Py<T>::clone()`. This was disabled by default in pyo3 0.22 because of a soundness issue around calling that in situations when the GIL was not held. [1] Right now qiskit relies on using `Clone` on `Py` objects because we have container types that own a `PyObject` that we sometimes clone at the top level so this flag needs to be set. In the future we can look at adding interfaces to avoid needing this flag in the future. Another thing to note is that rust-numpy includes support for ndarray 0.16, however this PR doesn't migrate to it because `ndarray_einsum_beta` used in the `qiskit_accelerate::unitary_compose` module still depends on ndarray 0.15 and we can't upgrade until that does. [1] https://pyo3.rs/v0.22.3/migration#pyclone-is-now-gated-behind-the-py-clone-feature
|
One or more of the following people are relevant to this code:
|
mtreinish
added
Rust
Pull Request Test Coverage Report for Build 11298339065Details
💛 - Coveralls |
kevinhartman
approved these changes
Oct 11, 2024
| @@ -613,6 +613,7 @@ impl CommutationLibrary { | |||
| #[pymethods] | |||
| impl CommutationLibrary { | |||
| #[new] | |||
| #[pyo3(signature=(py_any=None))] | |||
There was a problem hiding this comment.
They finally got rid of the automatic optional stuff I see!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit migrates to using PyO3 0.22 and rust-numpy and updates all the deprecated and changed interfaces in the libraries to their new syntax. No new or alternative interfaces are used as part of this PR except for where deprecation warnings pointed to do so.
One thing to note is that in pyo3 0.22 a new feature py-clone was added to re-enable
Py<T>::clone(). This was disabled by default in pyo3 0.22 because of a soundness issue around calling that in situations when the GIL was not held. [1] Right now qiskit relies on usingCloneonPyobjects because we have container types that own aPyObjectthat we sometimes clone at the top level so this flag needs to be set. This only occurs in thecircuitcrate. In the future we can look at adding interfaces to avoid needing this flag in the future.Another thing to note is that rust-numpy includes support for ndarray 0.16, however this PR doesn't migrate to it because
ndarray_einsum_betaused in theqiskit_accelerate::unitary_composemodule still depends on ndarray 0.15 and we can't upgrade until that does.Details and comments
[1] https://pyo3.rs/v0.22.3/migration#pyclone-is-now-gated-behind-the-py-clone-feature