Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo on api/qiskit/providers page #13296

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fixes typo on api/qiskit/providers page #13296

merged 2 commits into from
Oct 10, 2024

Conversation

LeanderCS
Copy link
Contributor

Summary

Fixes #13211

Fixed typo on the api/qiskit/providers page where the QuantumCircuit variable qc was incorrectly called as c.

No tests are needed.

Details and comments


@LeanderCS LeanderCS requested review from jyu00 and a team as code owners October 8, 2024 12:55
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Oct 8, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11241388480

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 166 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 88.86%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 5 91.48%
crates/qasm2/src/parse.rs 12 96.69%
crates/circuit/src/operations.rs 148 89.43%
Totals Coverage Status
Change from base Build 11225763971: -0.01%
Covered Lines: 74737
Relevant Lines: 84106

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. We typically don't add release notes for documentation fixes, so my only comment is that I'd remove the release note.

@LeanderCS
Copy link
Contributor Author

Thanks for your contribution. We typically don't add release notes for documentation fixes, so my only comment is that I'd remove the release note.

Thanks, didn't know it.
I will do it right away.

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElePT ElePT added this pull request to the merge queue Oct 10, 2024
Merged via the queue into Qiskit:main with commit 48d2492 Oct 10, 2024
15 checks passed
@raynelfss raynelfss added the Changelog: None Do not include in changelog label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Typo on api/qiskit/providers page
5 participants