Fix qft-plugins for custom 'qft' gates #13181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderivrii
requested review from
ShellyGarion and
a team
as code owners
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10923804686Details
💛 - Coveralls |
alexanderivrii
added
the
Changelog: Bugfix
mtreinish
added
the
stable backport potential
jakelishman
approved these changes
Sep 19, 2024
Comment on lines
+2324
to
+2326
| # HighLevelSynthesis should replace the custom gate called "qft" | ||
| # by the user-provided definition. | ||
| self.assertEqual(Operator(qc2), Operator(qct)) |
There was a problem hiding this comment.
This test confused me at first, because I was expecting the test to be that HighLevelSynthesis had not turned it into a QFT equivalent, but the trick is that qc2 doesn't actually encode a QFT, so the test does the right thing.
I'm fine to merge like this, just commenting more because I got a bit confused and felt like broadcasting that fact.
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 2245a4f) # Conflicts: # qiskit/transpiler/passes/synthesis/hls_plugins.py # test/python/transpiler/test_high_level_synthesis.py
jakelishman
added a commit
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 2245a4f)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 2245a4f) Co-authored-by: Jake Lishman <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 2245a4f) Co-authored-by: Jake Lishman <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 2245a4f) Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
HighLevelSynthesistranspiler pass no longer raises an exception when encountering a custom gate that is called "qft" but is not an instance of classQFTGate. Instead, the synthesis plugins for QFT gates ignore such a gate, and the gate's definition is used (if provided).Fixes #13120 and #13174.
The PR is very short and has backport potential (if desired).