Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of qasm2.CustomInstruction #13167

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add example of qasm2.CustomInstruction #13167

merged 1 commit into from
Sep 18, 2024

Conversation

jakelishman
Copy link
Member

Summary

We didn't have an explicit usage example of this in the documentation before, and several people seem to have been confused by it.

Details and comments

For example, #13166.

@jakelishman
Add example of qasm2.CustomInstruction
87b2872 
We didn't have an explicit usage example of this in the documentation
before, and several people seem to have been confused by it.
@jakelishman jakelishman added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable mod: qasm2 Relating to OpenQASM 2 import or export Changelog: None Do not include in changelog labels Sep 17, 2024
@jakelishman jakelishman added this to the 1.2.2 milestone Sep 17, 2024
@jakelishman jakelishman requested a review from a team as a code owner September 17, 2024 14:06
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10904762632

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 88.917%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 8 91.73%
Totals Coverage Status
Change from base Build 10892476121: 0.01%
Covered Lines: 73473
Relevant Lines: 82631
💛 - Coveralls

ElePT
ElePT approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue Sep 18, 2024
Merged via the queue into Qiskit:main with commit f091cf2 Sep 18, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@jakelishman @mergify
Add example of qasm2.CustomInstruction (#13167)
58c1d9b 
We didn't have an explicit usage example of this in the documentation
before, and several people seem to have been confused by it.

(cherry picked from commit f091cf2)
@mergify mergify bot mentioned this pull request Sep 18, 2024
Merged
@jakelishman jakelishman deleted the qasm2/explicit-custom-examples branch September 18, 2024 09:18
github-merge-queue bot pushed a commit that referenced this pull request Sep 18, 2024
@mergify @jakelishman
Add example of qasm2.CustomInstruction (#13167) (#13175)
95921da 
We didn't have an explicit usage example of this in the documentation
before, and several people seem to have been confused by it.

(cherry picked from commit f091cf2)

Co-authored-by: Jake Lishman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation mod: qasm2 Relating to OpenQASM 2 import or export stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jakelishman @qiskit-bot @coveralls @ElePT