Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ensure CollectAndCollapse is part of the public API #13071

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mrossinek
Copy link
Member

Summary

As discussed offline, this ensures that the CollectAndCollapse transpiler pass is actually part of the public API.

Details and comments

I am not sure whether this requires a release note... 🤔

@mrossinek mrossinek requested a review from a team as a code owner September 2, 2024 13:59
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max. If you feel like a release note would be particularly useful to people, feel free to add one, but we probably don't really need one - this was announced as if it were public API, already was intended to be, and we don't typically have release notes for documentation-only changes.

Let me know either way and I'll tag for merge.

@jakelishman jakelishman added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog mod: transpiler Issues and PRs related to Transpiler labels Sep 2, 2024
@jakelishman jakelishman added this to the 1.2.1 milestone Sep 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10668553853

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 89.163%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.48%
Totals Coverage Status
Change from base Build 10667735969: 0.02%
Covered Lines: 71841
Relevant Lines: 80573

💛 - Coveralls

@mrossinek
Copy link
Member Author

Thanks Max. If you feel like a release note would be particularly useful to people, feel free to add one, but we probably don't really need one - this was announced as if it were public API, already was intended to be, and we don't typically have release notes for documentation-only changes.

Let me know either way and I'll tag for merge.

Sounds good 👍 I don't think a release note would add much value here so I would go with this as is

@mrossinek mrossinek enabled auto-merge September 2, 2024 14:56
@mrossinek mrossinek added this pull request to the merge queue Sep 2, 2024
Merged via the queue into Qiskit:main with commit 3fac5da Sep 2, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@mrossinek mrossinek deleted the publicize-collect-and-collapse branch September 2, 2024 16:31
github-merge-queue bot pushed a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation mod: transpiler Issues and PRs related to Transpiler stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants