-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ensure CollectAndCollapse is part of the public API #13071
docs: ensure CollectAndCollapse is part of the public API #13071
Conversation
One or more of the following people are relevant to this code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Max. If you feel like a release note would be particularly useful to people, feel free to add one, but we probably don't really need one - this was announced as if it were public API, already was intended to be, and we don't typically have release notes for documentation-only changes.
Let me know either way and I'll tag for merge.
Pull Request Test Coverage Report for Build 10668553853Details
💛 - Coveralls |
Sounds good 👍 I don't think a release note would add much value here so I would go with this as is |
(cherry picked from commit 3fac5da)
…13073) (cherry picked from commit 3fac5da) Co-authored-by: Max Rossmannek <[email protected]>
Summary
As discussed offline, this ensures that the
CollectAndCollapse
transpiler pass is actually part of the public API.Details and comments
I am not sure whether this requires a release note... 🤔