Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding copy argument to QFTGate.__array__ (backport #12979) #12987

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 19, 2024

Summary

Fixes numpy support for QFTGate: the QFT gate PR was developed in parallel with #11999 and did not get the required upgrade.


This is an automatic backport of pull request #12979 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner August 19, 2024 14:11
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Aug 19, 2024
@ElePT ElePT enabled auto-merge August 19, 2024 14:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10455010104

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.836%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/circuit/library/basis_change/qft.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 4 91.98%
Totals Coverage Status
Change from base Build 10410180245: 0.02%
Covered Lines: 66814
Relevant Lines: 74373

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 19, 2024
@ElePT ElePT added this pull request to the merge queue Aug 20, 2024
Merged via the queue into stable/1.2 with commit 21da5e3 Aug 20, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-12979 branch August 20, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants