Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve public type annotations for OneQubitEulerDecomposer #12530

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Improve public type annotations for OneQubitEulerDecomposer #12530

merged 1 commit into from
Jun 10, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented Jun 7, 2024

Summary

I noticed an incorrect/incomplete return type annotation for OneQubitEulerDecomposer.__call__ and also added an annotation for build_circuit.

Details and comments

@garrison garrison requested review from alexanderivrii, ShellyGarion and a team as code owners June 7, 2024 20:09
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9422567134

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.566%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/synthesis/one_qubit/one_qubit_decompose.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 92.11%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 9418156791: -0.02%
Covered Lines: 62438
Relevant Lines: 69712
💛 - Coveralls

@1ucian0 1ucian0 added the Changelog: None Do not include in changelog label Jun 10, 2024
@1ucian0 1ucian0 added this pull request to the merge queue Jun 10, 2024
Merged via the queue into Qiskit:main with commit b2c3ffd Jun 10, 2024
15 checks passed
@garrison garrison deleted the one_qubit_decompose_annotations branch June 10, 2024 12:28
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
@garrison @Procatv
Improve public type annotations for OneQubitEulerDecomposer (Qiskit…
cd92b1a 
…#12530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 approved these changes

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii alexanderivrii is a code owner

@ShellyGarion ShellyGarion Awaiting requested review from ShellyGarion ShellyGarion is a code owner

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garrison @qiskit-bot @coveralls @1ucian0