Fix QuantumCircuit.depth with zero-operands and Expr nodes
#12429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes `QuantumCircuit.depth` to correctly handle cases where a circuit instruction has zero operands (such as `GlobalPhaseGate`), and to treat classical bits and real-time variables used inside `Expr` conditions as part of the depth calculations. This is in line with `DAGCircuit`. This commit still does not add the same `recurse` argument from `DAGCircuit.depth`, because the arguments for not adding it to `QuantumCircuit.depth` at the time still hold; there is no clear meaning to it for general control flow from a user's perspective, and it was only added to the `DAGCircuit` methods because there it is more of a proxy for optimising over all possible inner blocks.
jakelishman
added
stable backport potential
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9128390726Details
💛 - Coveralls |
ElePT
reviewed
Jun 7, 2024
| @@ -3307,6 +3307,9 @@ def depth( | |||
| ) -> int: | |||
| """Return circuit depth (i.e., length of critical path). | |||
|
|
|||
| .. warning:: | |||
| This operation is not well defined if the circuit contains control-flow operations. | |||
There was a problem hiding this comment.
would it make sense to add more info in this warning? would it be inaccurate to say, for example:
Suggested change
| This operation is not well defined if the circuit contains control-flow operations. | |
| This operation is not well defined if the circuit contains control-flow operations, but | |
| their variables and clbits are counted in the depth calculation. | |
There was a problem hiding this comment.
I was mostly deliberately trying to avoid saying anything about what happens in the return value of this if there's control-flow operations, since the whole result is ill defined. I didn't want to commit to anything one way or the other.
There was a problem hiding this comment.
I suspected that was the case, and I think that makes sense too.
ElePT
approved these changes
Jun 7, 2024
| @@ -3307,6 +3307,9 @@ def depth( | |||
| ) -> int: | |||
| """Return circuit depth (i.e., length of critical path). | |||
|
|
|||
| .. warning:: | |||
| This operation is not well defined if the circuit contains control-flow operations. | |||
There was a problem hiding this comment.
I suspected that was the case, and I think that makes sense too.
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
This causes `QuantumCircuit.depth` to correctly handle cases where a circuit instruction has zero operands (such as `GlobalPhaseGate`), and to treat classical bits and real-time variables used inside `Expr` conditions as part of the depth calculations. This is in line with `DAGCircuit`. This commit still does not add the same `recurse` argument from `DAGCircuit.depth`, because the arguments for not adding it to `QuantumCircuit.depth` at the time still hold; there is no clear meaning to it for general control flow from a user's perspective, and it was only added to the `DAGCircuit` methods because there it is more of a proxy for optimising over all possible inner blocks. (cherry picked from commit d18a74c)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
… (#12528) This causes `QuantumCircuit.depth` to correctly handle cases where a circuit instruction has zero operands (such as `GlobalPhaseGate`), and to treat classical bits and real-time variables used inside `Expr` conditions as part of the depth calculations. This is in line with `DAGCircuit`. This commit still does not add the same `recurse` argument from `DAGCircuit.depth`, because the arguments for not adding it to `QuantumCircuit.depth` at the time still hold; there is no clear meaning to it for general control flow from a user's perspective, and it was only added to the `DAGCircuit` methods because there it is more of a proxy for optimising over all possible inner blocks. (cherry picked from commit d18a74c) Co-authored-by: Jake Lishman <[email protected]>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
…t#12429) This causes `QuantumCircuit.depth` to correctly handle cases where a circuit instruction has zero operands (such as `GlobalPhaseGate`), and to treat classical bits and real-time variables used inside `Expr` conditions as part of the depth calculations. This is in line with `DAGCircuit`. This commit still does not add the same `recurse` argument from `DAGCircuit.depth`, because the arguments for not adding it to `QuantumCircuit.depth` at the time still hold; there is no clear meaning to it for general control flow from a user's perspective, and it was only added to the `DAGCircuit` methods because there it is more of a proxy for optimising over all possible inner blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This causes
QuantumCircuit.depthto correctly handle cases where a circuit instruction has zero operands (such asGlobalPhaseGate), and to treat classical bits and real-time variables used insideExprconditions as part of the depth calculations. This is in line withDAGCircuit.This commit still does not add the same
recurseargument fromDAGCircuit.depth, because the arguments for not adding it toQuantumCircuit.depthat the time still hold; there is no clear meaning to it for general control flow from a user's perspective, and it was only added to theDAGCircuitmethods because there it is more of a proxy for optimising over all possible inner blocks.Details and comments
Fix #12426.