-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standalone test file for Clifford synthesis functions #12347
Conversation
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8982134163Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much -- this makes the code cleaner and more efficient (in particular avoiding to copy the subcircuits in clifford synthesis algorithms). My only real suggestion was to move the random clifford generation circuit directly to Qiskit (and remove its support for V and W gates that are not available in the standard library). Of course, that also means that you would need the release notes :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM!
* Convert synthesis imports to runtime imports to avoid cyclic import errors * Set copy=False in append * Move clifford synthesis tests to separate file in test/synthesis. * Add random_clifford_circuit to qiskit.circuit.random * Remove pylint disable * Fix reno
Summary
This PR is a spin-off from #12203 with a few minor improvements to the synthesis functions:
test/python/synthesis
instead oftest/python/quantum_info
DAGCircuit
insideqiskit.synthesis
in Add support for high level synthesis plugins to return a DAGCircuit #12203, which would normally raise a cyclic import error)copy=False
tocircuit.append
Details and comments