Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove qiskit-ibm-provider as an example in README.md #12035

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Remove qiskit-ibm-provider as an example in README.md #12035

merged 1 commit into from
Mar 18, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Mar 18, 2024

Summary

With Qiskit/qiskit-ibm-runtime#1285, the use of qiskit-ibm-provider is discouraged.

Details and comments

Includes some links pointing to qiskit-terra repo

@1ucian0 1ucian0 requested a review from a team as a code owner March 18, 2024 14:21
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

ElePT
ElePT approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElePT ElePT enabled auto-merge March 18, 2024 14:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8328223470

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 89.308%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 91.69%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 8327441128: 0.002%
Covered Lines: 59796
Relevant Lines: 66955
💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Mar 18, 2024
Merged via the queue into Qiskit:main with commit ad0b7f2 Mar 18, 2024
12 checks passed
@sbrandhsn sbrandhsn added the Changelog: None Do not include in changelog label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1ucian0 @qiskit-bot @coveralls @ElePT @sbrandhsn