Fix handling of control flow instructions in convert_to_target() #11922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the convert_to_target() function where it wasn't looking for control flow instructions in the proper location. Typically the control flow instructions are put in the supported_instructions field of the BackendConfiguration, but the convert_to_target() function was ignoring this field. This commit updates the function to check supported_instructions for the control flow instructions. It doesn't more broadly look at the supported_instructions field, because on other backends this field is used to list the supported pulse instructions which might have name conflicts with other instructions and cause issues building a target. This is the spiritual backport of Qiskit#11877, but because the state of the convert_to_target() function on stable/0.46 is very different very little code is carried over from the version on main and stable/1.0, basically only the tests. This is actually closer in implementation to the equivalent PR on qiskit-ibm-runtime: Qiskit/qiskit-ibm-runtime#1443 as the internal conversion function in that repository is very similar to the function on the stable/0.46 branch.
mtreinish
added
the
Changelog: Bugfix
|
One or more of the the following people are requested to review this:
|
jakelishman
approved these changes
Feb 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes an issue in the convert_to_target() function where it wasn't looking for control flow instructions in the proper location. Typically the control flow instructions are put in the supported_instructions field of the BackendConfiguration, but the convert_to_target() function was ignoring this field. This commit updates the function to check supported_instructions for the control flow instructions. It doesn't more broadly look at the supported_instructions field, because on other backends this field is used to list the supported pulse instructions which might have name conflicts with other instructions and cause issues building a target.
This is the spiritual backport of #11877, but because the state of the convert_to_target() function on stable/0.46 is very different very little code is carried over from the version on main and stable/1.0, basically only the tests. This is actually closer in implementation to the equivalent PR on qiskit-ibm-runtime: Qiskit/qiskit-ibm-runtime#1443 as the internal conversion function in that repository is very similar to the function on the stable/0.46 branch.
Details and comments