Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hint and doc of StatevectorEstimator.default_precision #11910

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix type hint and doc of StatevectorEstimator.default_precision #11910

merged 1 commit into from
Feb 29, 2024

Conversation

t-imamichi
Copy link
Member

Summary

StatevectorEstimator.default_precision looks a copy of StatevectorSampler.default_shots.
It should be float as defined in the constructor.

Details and comments

@t-imamichi t-imamichi requested review from a team as code owners February 28, 2024 14:18
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @t-imamichi

ihincks
ihincks approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@ihincks ihincks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you for catching this.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8081848528

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 89.335%
Files with Coverage Reduction New Missed Lines %
qiskit/primitives/statevector_estimator.py 1 94.55%
crates/qasm2/src/lex.rs 3 92.44%
Totals Coverage Status
Change from base Build 8080511026: 0.01%
Covered Lines: 59154
Relevant Lines: 66216
💛 - Coveralls

@t-imamichi t-imamichi added mod: primitives Related to the Primitives module Changelog: None Do not include in changelog labels Feb 29, 2024
@jakelishman jakelishman added this pull request to the merge queue Feb 29, 2024
@jakelishman jakelishman added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Feb 29, 2024
@jakelishman jakelishman added this to the 1.0.2 milestone Feb 29, 2024
Merged via the queue into Qiskit:main with commit 8acc766 Feb 29, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
@t-imamichi @mergify
fix type hint and doc (#11910)
0602da6 
(cherry picked from commit 8acc766)
@mergify mergify bot mentioned this pull request Feb 29, 2024
Merged
@t-imamichi t-imamichi deleted the fix-default-precision branch February 29, 2024 02:27
github-merge-queue bot pushed a commit that referenced this pull request Feb 29, 2024
@mergify @t-imamichi
fix type hint and doc (#11910) (#11918)
952b988 
(cherry picked from commit 8acc766)

Co-authored-by: Takashi Imamichi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihincks ihincks ihincks approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog mod: primitives Related to the Primitives module stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
5 participants
@t-imamichi @qiskit-bot @coveralls @ihincks @jakelishman