Fix improper handling of BindingsArray in EstimatorPub.coerce()
#11871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihincks
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8020960195Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
(cherry picked from commit aba7c0f)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
#11881) (cherry picked from commit aba7c0f) Co-authored-by: Ian Hincks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a bug in
EstimatorPub.coerce()where if an actualBindingsArrayis passed in the third slot, then it attempts to send{params: bindings_array}toBindingsArray.coercerather thanbindings_array, which raises a ValueError. This PR fixes this behaviour by passing the bindings array through.Details and comments
Since Neither
BindingsArraynotEstimatorPubare (currently) part of the public interface, this is a low impact bug for non-developers.