-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fake generic and modify tests (backport #10266) #11670
Conversation
* Added a FakeGeneric BackendV2 backend, this is just a bare minimum working code * All FakeBackends (like FakeMelbourne, FakeBoeblingen ,etc) is replaced with FakeGeneric * relocated FakeGeneric in fake_provider directory; replaced if-elif with instruction_dict in fake_generic.py; added support of grid type of coupling map; using lower number of qubits, passed all tests of test_transpiler except one method ( test_parallel_dispatch_lazy_cal_loading ) * added tests for FakeGeneric * This commit just reformats test_transpiler.py fake_generic.py and test_fake_generic.py * Update qiskit/providers/fake_provider/fake_generic.py Co-authored-by: atharva-satpute <[email protected]> * Update qiskit/providers/fake_provider/fake_generic.py Co-authored-by: atharva-satpute <[email protected]> * Update test/python/providers/fake_provider/test_fake_generic.py Co-authored-by: atharva-satpute <[email protected]> * Update test/python/providers/fake_provider/test_fake_generic.py Co-authored-by: atharva-satpute <[email protected]> * Fix some tests * Add calibration schedules, fix transpiler tests * Fix lint * Refactor, add pulse functionality * Latest updates to FakeGeneric * Fix some unit tests * Fix some unit tests * Fix tests, lint, refactor * Remove unused inputs * Make calibrations optional * Attempt to speed up test: only add calibrations if option enabled * Revert some tests to V1 * Refactor FakeGeneric * Update unit test * Rename supported instructions to operations, fix tests Fix test seed Fix unit test, lint * Restore vf2postlayout test to V1 Fx vf2 test * Add pulse test to validate pulse capabilities of new fake backend Update fake generic * Update docs, fix lint * Avoid set for basis gates to allow reproducibility in the error/duration value generation * Update calibrations * Fix transpiler test * Add run test to confirm noise defaults * Add CZ to basis gates, dtm, update backend names, fix docs * Remove GenericTarget, add default for basis_gates, remove supported_operations. * Apply review comments, modify calibrate_instructions to avoid public calibration method. * New name proposal * Fix lint and test * Fix comment * Apply Kevin's suggestions to extract defaults from class * Make defaults private * Fix lint * Revert previous 3 comments. * Privatize GenericFakeBackend * Remove from docs * Revert privatization * Apply review comments * Add reno * Fix lint * Apply suggestions from Matt's code review Co-authored-by: Matthew Treinish <[email protected]> * Apply comments from code review * Fix lint * Rename to GenericBackendV2 and adjust docs. * Fix lint * Apply comments from code review * It's not 2023 anymore * Fix conflict * Fix test conflict. --------- Co-authored-by: atharva-satpute <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Kevin Hartman <[email protected]> (cherry picked from commit b4582a9) # Conflicts: # qiskit/providers/fake_provider/__init__.py # test/python/compiler/test_transpiler.py
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7711917950
💛 - Coveralls |
* Rename test, switch to basic simulator * Fix bug in pulse default generation
This is an automatic backport of pull request #10266 done by Mergify.
Cherry-pick of b4582a9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com