Revert memory-owning expr.Var nodes
#11667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
|
Ach, I've borked this pretty badly and need to redo it, possibly by avoiding |
This commit is a roll-up reversion of the following commits (PR): * commit a79e879 (Qiskit#10977) * commit ba161e9 (Qiskit#10974) * commit 50e8137 (Qiskit#10944) This is being done to clear the 1.0 branch of memory-owning `expr.Var` variables and `Store` instructions. It should be re-applied once 1.0 is released. This wasn't done by individual `revert` operations, because there were also significant structural changes introduced in those PRs that were very valid and should be maintained. Cross-references to `Var` nodes from other functions have been removed for now. Making `Var` and `types.Type` hashable is maintained, as is the `Var.standalone` function, in order to prepare the ground for the inclusion of proper `Var` nodes in a minor release.
jakelishman
force-pushed
the
var/revert
branch
from
33ba003 to
cfb317e
Compare
|
Ok, I redid the reversion much more manually, and this should be rather better now. |
Pull Request Test Coverage Report for Build 7700797447
💛 - Coveralls |
mtreinish
approved these changes
Jan 29, 2024
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Feb 16, 2024
This reverts commit 052d889.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit is a roll-up reversion of the following commits (PR):
QuantumCircuit.appendvalidates captures in control-flow #10974)Varnodes #10944)This is being done to clear the 1.0 branch of memory-owning
expr.Varvariables andStoreinstructions. It should be re-applied once 1.0 is released.This wasn't done by individual
revertoperations, because there were also significant structural changes introduced in those PRs that were very valid and should be maintained. Cross-references toVarnodes from other functions have been removed for now.Making
Varandtypes.Typehashable is maintained, as is theVar.standalonefunction, in order to prepare the ground for the inclusion of properVarnodes in a minor release.Details and comments