Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lurking qiskit.tools usage #11625

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

jakelishman
Copy link
Member

Summary

A few places in docstrings where we'd left in references to qiskit.tools. At least one of these was executed as part of the documentation build, so was causing failures that weren't being caught because tox is currently building an invalid environment for the docs for Qiskit 1.0.

Details and comments

These are true Qiskit-1.0 bugs that fixing the tox environment in #11621 found.

A few places in docstrings where we'd left in references to
`qiskit.tools`.  At least one of these was executed as part of the
documentation build, so was causing failures that weren't being caught
because `tox` is currently building an invalid environment for the docs
for Qiskit 1.0.
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Jan 23, 2024
@jakelishman jakelishman added this to the 1.0.0 milestone Jan 23, 2024
@jakelishman jakelishman requested review from nonhermitian and a team as code owners January 23, 2024 11:51
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

@sbrandhsn
Copy link
Contributor

LGTM, I suspect random_unitary is now always available when make_circuit_ring is called and seed_mapper is simply not used anymore or seeded by seed_transpiler? Do you think seed_mapper should also be removed from randomized_benchmarking.py?

@coveralls
Copy link

coveralls commented Jan 23, 2024

Pull Request Test Coverage Report for Build 7625560079

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 89.502%

Totals Coverage Status
Change from base Build 7623118598: -0.01%
Covered Lines: 59489
Relevant Lines: 66467

💛 - Coveralls

Co-authored-by: Sebastian Brandhofer <[email protected]>
@jakelishman
Copy link
Member Author

Yeah, the old qiskit.tools.qi.qi (or whatever it was) is from years ago - before I joined IBM, and seed_mapper is what the argument to transpile (and execute, at the time) used to be called similarly years ago.

Thanks for spotting those other imports - yeah, it makes sense to squash them all at once. asv may start a new trace for those test files due to modification of the test, but I'm not 100% sure if it counts stuff in the imports towards the hash of the tests. It's not a big deal, just probably best to get everything squashed in one go.

@jakelishman jakelishman enabled auto-merge January 23, 2024 12:22
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't be able to use the benchmarks with Qiskit pre-0.10.0 anymore (I remember adding that logic when the interface changed), but I guess that doesn't matter :)

@jakelishman jakelishman added this pull request to the merge queue Jan 23, 2024
Merged via the queue into Qiskit:main with commit fdc18d4 Jan 23, 2024
12 checks passed
@jakelishman jakelishman deleted the fix-tools-imports branch January 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants