-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lurking qiskit.tools
usage
#11625
Conversation
A few places in docstrings where we'd left in references to `qiskit.tools`. At least one of these was executed as part of the documentation build, so was causing failures that weren't being caught because `tox` is currently building an invalid environment for the docs for Qiskit 1.0.
One or more of the the following people are requested to review this:
|
LGTM, I suspect |
Pull Request Test Coverage Report for Build 7625560079
💛 - Coveralls |
Co-authored-by: Sebastian Brandhofer <[email protected]>
Yeah, the old Thanks for spotting those other imports - yeah, it makes sense to squash them all at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't be able to use the benchmarks with Qiskit pre-0.10.0 anymore (I remember adding that logic when the interface changed), but I guess that doesn't matter :)
Summary
A few places in docstrings where we'd left in references to
qiskit.tools
. At least one of these was executed as part of the documentation build, so was causing failures that weren't being caught becausetox
is currently building an invalid environment for the docs for Qiskit 1.0.Details and comments
These are true Qiskit-1.0 bugs that fixing the tox environment in #11621 found.