-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add other primitives team members to CODEOWNERS #11525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
type: qa
Issues and PRs that relate to testing and code quality
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Changelog: None
Do not include in changelog
labels
Jan 9, 2024
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7464156207
💛 - Coveralls |
mtreinish
reviewed
Jan 9, 2024
Co-authored-by: Matthew Treinish <[email protected]>
mtreinish
approved these changes
Jan 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Add other primitives team members to CODEOWNERS * Switch to using a team Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 2d04bad)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Add other primitives team members to CODEOWNERS * Switch to using a team Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 2d04bad) Co-authored-by: Jake Lishman <[email protected]>
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
* Add other primitives team members to CODEOWNERS * Switch to using a team Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: None
Do not include in changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
type: qa
Issues and PRs that relate to testing and code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We might want to replace this in the future with a primitives team, but for the immediate term, this corrects the oversight that Chris and Ian aren't in it. Chris technically has legacy permissions from terra-core, but isn't actually part of the core Terra team these days, so I've added him explicitly.
Details and comments