Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other primitives team members to CODEOWNERS #11525

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

jakelishman
Copy link
Member

Summary

We might want to replace this in the future with a primitives team, but for the immediate term, this corrects the oversight that Chris and Ian aren't in it. Chris technically has legacy permissions from terra-core, but isn't actually part of the core Terra team these days, so I've added him explicitly.

Details and comments

@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jan 9, 2024
@jakelishman jakelishman requested a review from a team as a code owner January 9, 2024 15:56
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7464156207

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.574%

Totals Coverage Status
Change from base Build 7463210826: 0.01%
Covered Lines: 59468
Relevant Lines: 67906

💛 - Coveralls

.github/CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Matthew Treinish <[email protected]>
@mtreinish mtreinish enabled auto-merge January 9, 2024 17:46
@mtreinish mtreinish added this pull request to the merge queue Jan 9, 2024
Merged via the queue into Qiskit:main with commit 2d04bad Jan 9, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
* Add other primitives team members to CODEOWNERS

* Switch to using a team

Co-authored-by: Matthew Treinish <[email protected]>

---------

Co-authored-by: Matthew Treinish <[email protected]>
(cherry picked from commit 2d04bad)
@jakelishman jakelishman deleted the add-primitives-codeowners branch January 9, 2024 20:58
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2024
* Add other primitives team members to CODEOWNERS

* Switch to using a team

Co-authored-by: Matthew Treinish <[email protected]>

---------

Co-authored-by: Matthew Treinish <[email protected]>
(cherry picked from commit 2d04bad)

Co-authored-by: Jake Lishman <[email protected]>
ShellyGarion pushed a commit to ShellyGarion/qiskit-terra that referenced this pull request Jan 18, 2024
* Add other primitives team members to CODEOWNERS

* Switch to using a team

Co-authored-by: Matthew Treinish <[email protected]>

---------

Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants